From: Alexander Graf <agraf@suse.de>
To: reza.jelveh@tuhh.de, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, pbonzini@redhat.com, jsnow@redhat.com
Subject: Re: [Qemu-devel] [PATCH_v2] ahci.c: mask unused flags when reading size PRDT DBC
Date: Tue, 01 Jul 2014 13:19:03 +0200 [thread overview]
Message-ID: <53B29927.6060801@suse.de> (raw)
In-Reply-To: <1404213207-89115-1-git-send-email-reza.jelveh@tuhh.de>
On 01.07.14 13:13, reza.jelveh@tuhh.de wrote:
> From: Reza Jelveh <reza.jelveh@tuhh.de>
>
> The data byte count(DBC) read from the description information is defined for
> bits 21:00. Bits 30:22 are reserved and bit 31 is the Interrupt on Completion
> (I) flag.
>
> Completion interrupts are triggered after every transaction instead of on
> I-flag in QEMU. tbl_entry_size is a signed integer and improperly reading the
> DBC leads to a negative offset that causes sglist allocation to fail.
>
> Signed-off-by: Reza Jelveh <reza.jelveh@tuhh.de>
> ---
> This requires a custom ovmf image with sata controller for testing:
>
> http://reza.jelveh.me/assets/OVMF.fd.bz2
>
> Signed-off-by: Reza Jelveh <reza.jelveh@tuhh.de>
Reviewed-by: Alexander Graf <agraf@suse.de>
I'm still puzzled that this ever worked at all ;).
Alex
next prev parent reply other threads:[~2014-07-01 11:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 11:13 [Qemu-devel] [PATCH_v2] ahci.c: mask unused flags when reading size PRDT DBC reza.jelveh
2014-07-01 11:19 ` Alexander Graf [this message]
2014-07-01 11:36 ` Kevin Wolf
2014-07-01 11:49 ` Alexander Graf
2014-07-01 14:47 ` John Snow
2014-07-12 0:24 ` John Snow
2014-07-02 8:17 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B29927.6060801@suse.de \
--to=agraf@suse.de \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=reza.jelveh@tuhh.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).