From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X21c1-0007sV-OH for qemu-devel@nongnu.org; Tue, 01 Jul 2014 13:13:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X21bw-0003ld-QX for qemu-devel@nongnu.org; Tue, 01 Jul 2014 13:12:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X21bw-0003kc-HJ for qemu-devel@nongnu.org; Tue, 01 Jul 2014 13:12:52 -0400 Message-ID: <53B2EC11.70802@redhat.com> Date: Tue, 01 Jul 2014 11:12:49 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403889855-5740-1-git-send-email-armbru@redhat.com> <1403889855-5740-4-git-send-email-armbru@redhat.com> In-Reply-To: <1403889855-5740-4-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Boi1a0CtaVmDCWrGrBxCDHnQU5C766FLx" Subject: Re: [Qemu-devel] [PATCH v2 2.1 3/3] docs/qmp: Fix documentation of BLOCK_JOB_READY to match code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, wenchaoqemu@gmail.com, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Boi1a0CtaVmDCWrGrBxCDHnQU5C766FLx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/27/2014 11:24 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > docs/qmp/qmp-events.txt | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) >=20 > diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt > index 22fea58..44be891 100644 > --- a/docs/qmp/qmp-events.txt > +++ b/docs/qmp/qmp-events.txt > @@ -157,12 +157,20 @@ Emitted when a block job is ready to complete. > =20 > Data: > =20 > -- "device": device name (json-string) > +- "type": Job type (json-string; "stream" for image streaming > + "commit" for block commit) > +- "device": Device name (json-string) > +- "len": Maximum progress value (json-int) > +- "offset": Current progress value (json-int) > + On success this is equal to len. > + On failure this is less than len. > +- "speed": Rate limit, bytes per second (json-int) > =20 Design question - if BLOCK_JOB_READY reports failure (that is, offset < len), are we still guaranteed to get a BLOCK_JOB_COMPLETED that also reports failure, or does 'query-blockjobs' completely forget about the job? If the job is completely lost, what recourse does management have to learn about the failure (that is, if libvirtd restarts, how will it learn whether a previously running job was aborted due to an error, if it missed the event)? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Boi1a0CtaVmDCWrGrBxCDHnQU5C766FLx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTsuwRAAoJEKeha0olJ0NqtsYH/3JlQOWWC4T8GbATb4kHNU5o AIN2lg1tDMx/15trrC+9+FbOOF7dyyFzp9eUeQxQ6ynvQoZfgNVkOhblHyyEyru/ kQMVYF9n8h/ewDTLNwmWNw4UqfHuS0pxoswXtUC+xCYRVxeYN0q5/NxrJjDSvOj6 1Y/GCWXDgK9WZ0fHzDOrRTzUPKkyXqRmfYUaTmuPvogtYiHMIXboAf56s5rv4vYq mIdPT4ttswZ06HqjFeNJd63CvtlD/Z0hvZY2NZsq2Ps9YUcvFjdumgvMQp0z8CXk lo4I8WUdpxNIZZl3BYj/0yHtmuKhA1f6s4oQnOvXA3KOWT9rfWrzOj3i2MYqdoQ= =VmQ4 -----END PGP SIGNATURE----- --Boi1a0CtaVmDCWrGrBxCDHnQU5C766FLx--