From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X21f2-0001Fs-UW for qemu-devel@nongnu.org; Tue, 01 Jul 2014 13:16:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X21ey-0004ym-0l for qemu-devel@nongnu.org; Tue, 01 Jul 2014 13:16:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X21ex-0004yi-NL for qemu-devel@nongnu.org; Tue, 01 Jul 2014 13:15:59 -0400 Message-ID: <53B2ECC9.8000400@redhat.com> Date: Tue, 01 Jul 2014 11:15:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <1404232537-28628-1-git-send-email-ming.lei@canonical.com> <1404232537-28628-5-git-send-email-ming.lei@canonical.com> In-Reply-To: <1404232537-28628-5-git-send-email-ming.lei@canonical.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="u1fpmJ2hppjBRITsVSHsDWrhkFEX7tX3Q" Subject: Re: [Qemu-devel] [PATCH v3 4/4] dataplane: submit I/O at batch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ming Lei , Peter Maydell , qemu-devel@nongnu.org, Paolo Bonzini , Stefan Hajnoczi Cc: Kevin Wolf , Fam Zheng , "Michael S. Tsirkin" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --u1fpmJ2hppjBRITsVSHsDWrhkFEX7tX3Q Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/01/2014 10:35 AM, Ming Lei wrote: > Before commit 580b6b2aa2(dataplane: use the Qemu block > layer for I/O), dataplane for virtio-blk submits block > I/O at batch. s/at/as a/ >=20 > This commit 580b6b2aa2 replaces the custom linux AIO > implementation(including I/O batch) with Qemu block s/(/ (/ > layer, but this commit causes ~40% throughput regression > on virtio-blk performance, and removing submitting I/O > at batch is one of the cause. s/at/as a/ >=20 > This patch applys the new introduced bdrv_io_plug() and s/applys/applies/ s/new/newly/ > bdrv_io_unplug() interfaces to support submitting I/O > at batch for Qemu block layer, and in my test, the change s/at/as a/ > can improve thoughput by ~30% with 'aio=3Dnative'. s/thoughput/throughput/ --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --u1fpmJ2hppjBRITsVSHsDWrhkFEX7tX3Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTsuzJAAoJEKeha0olJ0NqUAgH/3xqmo8Kaa7coGcki4CXBVhl abOiuBZiKom8k2kpwHskpyOtHSkenlHuHPejs50Sr2R3d/nB1FQ6FgSHYOpkgiYb 6jE4LpHXJyX4+82cIcl26Fg7gWGR+0rN/UTf7N8uhTHcjDDI5ir1ixMUROun0ZFO Whf4MApuS/dtASnXlzU4RYvuJCl2VWGJduGLLmobJH5Zga/sENGW/864wpA3lAts f/MmTgOwKEUbVbq8x/migsMnHkmriUYrgOz9fYtcXijMg7frV4jh2HiJhfMLbOaV /9rBAxeAnn8BNJjjyMhjs7OYl8kjpZLysnY2x6tX/8bKgGtRR9X4nFmh1QH4TXU= =uXw7 -----END PGP SIGNATURE----- --u1fpmJ2hppjBRITsVSHsDWrhkFEX7tX3Q--