qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Pavel Dovgaluk <Pavel.Dovgaluk@ispras.ru>,
	'QEMU Developers' <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [RFC PATCH 08/22] Monitor commands
Date: Tue, 01 Jul 2014 11:33:00 -0600	[thread overview]
Message-ID: <53B2F0CC.6010001@redhat.com> (raw)
In-Reply-To: <007c01cf951e$ea84e850$bf8eb8f0$@Dovgaluk@ispras.ru>

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

On 07/01/2014 05:23 AM, Pavel Dovgaluk wrote:
> This patch adds commands to control replay from the monitor.
> 
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@gmail.com>
> ---

What are the counterpart QMP commands?  It is seldom right to add an HMP
command unless the same thing can be done via QMP.


> @@ -2596,6 +2734,7 @@ int monitor_handle_fd_param2(Monitor *mon, const char *fdname, Error **errp)
>      return fd;
>  }
>  
> +
>  /* Please update hmp-commands.hx when adding or changing commands */
>  static mon_cmd_t info_cmds[] = {

Spurious newline addition?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2014-07-01 17:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01 11:23 [Qemu-devel] [RFC PATCH 08/22] Monitor commands Pavel Dovgaluk
2014-07-01 17:33 ` Eric Blake [this message]
2014-07-02 10:43   ` Pavel Dovgaluk
2014-07-02 10:54     ` Kirill Batuzov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B2F0CC.6010001@redhat.com \
    --to=eblake@redhat.com \
    --cc=Pavel.Dovgaluk@ispras.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).