From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33330)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1X21va-0006o8-G3
	for qemu-devel@nongnu.org; Tue, 01 Jul 2014 13:33:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1X21vV-0001vp-F1
	for qemu-devel@nongnu.org; Tue, 01 Jul 2014 13:33:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39719)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1X21vV-0001vj-65
	for qemu-devel@nongnu.org; Tue, 01 Jul 2014 13:33:05 -0400
Message-ID: <53B2F0CC.6010001@redhat.com>
Date: Tue, 01 Jul 2014 11:33:00 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <007c01cf951e$ea84e850$bf8eb8f0$@Dovgaluk@ispras.ru>
In-Reply-To: <007c01cf951e$ea84e850$bf8eb8f0$@Dovgaluk@ispras.ru>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="doXNsq3dTBpvQgNw5b8Dl194JxQWmi5Hd"
Subject: Re: [Qemu-devel] [RFC PATCH 08/22] Monitor commands
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Dovgaluk <Pavel.Dovgaluk@ispras.ru>, 'QEMU Developers' <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--doXNsq3dTBpvQgNw5b8Dl194JxQWmi5Hd
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 07/01/2014 05:23 AM, Pavel Dovgaluk wrote:
> This patch adds commands to control replay from the monitor.
>=20
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@gmail.com>
> ---

What are the counterpart QMP commands?  It is seldom right to add an HMP
command unless the same thing can be done via QMP.


> @@ -2596,6 +2734,7 @@ int monitor_handle_fd_param2(Monitor *mon, const =
char *fdname, Error **errp)
>      return fd;
>  }
> =20
> +
>  /* Please update hmp-commands.hx when adding or changing commands */
>  static mon_cmd_t info_cmds[] =3D {

Spurious newline addition?

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--doXNsq3dTBpvQgNw5b8Dl194JxQWmi5Hd
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJTsvDNAAoJEKeha0olJ0NqQjoH/RSSM8EoYJRMudukY1QBgKsB
UuRc7qobjTm9EtyBmUWX7OgFtHcNptwF44OvZDm8ssUAKnQSqyqjKStKvEa8Wr27
76mGdyTSL4dp3XaHprOWTKPbwU+HZiDb+AHn0sCH69kM/ut7Yz5fKTPKZanLe7r2
odVSchrNlHgJfaFAeQGdHapd+ngpJbmaz6qDBL3PmzvhAkSaiBxT8uv53GjTbs+5
0Mi7HAozqNecs5b8jGPrxys7dMM2O0yr/EMs2a4LOVMXnHh5C+ERaTgLuZLiAnnE
b8AVK6Udk6znfZOKQ1Zoz1HO+2bbItnKtpXjpvgIOVo6MXaLK2Uhn8ycD8YyV3Q=
=4lQF
-----END PGP SIGNATURE-----

--doXNsq3dTBpvQgNw5b8Dl194JxQWmi5Hd--