From: Eric Blake <eblake@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines
Date: Tue, 01 Jul 2014 14:42:43 -0600 [thread overview]
Message-ID: <53B31D43.2080000@redhat.com> (raw)
In-Reply-To: <20140627035020.GD4030@G08FNSTD100614.fnst.cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 1598 bytes --]
On 06/26/2014 09:50 PM, Hu Tao wrote:
> On Thu, Jun 26, 2014 at 10:55:33AM -0600, Eric Blake wrote:
>> On 06/26/2014 12:13 AM, Hu Tao wrote:
>>> We already have ROUND_UP but there are similar macros and ROUND_UP-like
>>> lines all around, replace them with ROUND_UP and clean up similar macros.
>>>
>>> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
>>> ---
>>
>> All of these conversions are correct, so:
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> Thanks for review!
>> tcg/ppc/tcg-target.c-#define FRAME_SIZE ((TCG_TARGET_CALL_STACK_OFFSET \
>> tcg/ppc/tcg-target.c- + TCG_STATIC_CALL_ARGS_SIZE \
>> tcg/ppc/tcg-target.c- + CPU_TEMP_BUF_SIZE \
>> tcg/ppc/tcg-target.c- + REG_SAVE_SIZE \
>> tcg/ppc/tcg-target.c- + TCG_TARGET_STACK_ALIGN - 1) \
>> tcg/ppc/tcg-target.c: & -TCG_TARGET_STACK_ALIGN)
>
> How did you find this one? Your pattern below just shows the last line.
But the last line had the word ALIGN in it, so I looked at the context
and found that it was indeed a rounding operation.
>> before I quit looking for more. (I just manually read through
>> git grep '[^&]& [~-]'
>> which has a lot of noise for non-rounding uses, but definitely found
>> some missed cases)
Are you going to submit a v2? As this does not appear to be a bug fix,
and today is hard freeze, this is probably 2.2 material.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-07-01 20:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 6:13 [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines Hu Tao
2014-06-26 11:52 ` Eric Blake
2014-06-27 3:41 ` Hu Tao
2014-06-26 16:55 ` Eric Blake
2014-06-27 3:50 ` Hu Tao
2014-07-01 20:42 ` Eric Blake [this message]
2014-07-02 7:56 ` Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B31D43.2080000@redhat.com \
--to=eblake@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).