From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X24tA-0003Xq-LQ for qemu-devel@nongnu.org; Tue, 01 Jul 2014 16:42:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X24t4-0006ww-GF for qemu-devel@nongnu.org; Tue, 01 Jul 2014 16:42:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X24t4-0006wp-8u for qemu-devel@nongnu.org; Tue, 01 Jul 2014 16:42:46 -0400 Message-ID: <53B31D43.2080000@redhat.com> Date: Tue, 01 Jul 2014 14:42:43 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403763216-28508-1-git-send-email-hutao@cn.fujitsu.com> <53AC5085.9040605@redhat.com> <20140627035020.GD4030@G08FNSTD100614.fnst.cn.fujitsu.com> In-Reply-To: <20140627035020.GD4030@G08FNSTD100614.fnst.cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HlqETrVeEx7vC3jH8jBvJ1k36UEb3OuMn" Subject: Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HlqETrVeEx7vC3jH8jBvJ1k36UEb3OuMn Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/26/2014 09:50 PM, Hu Tao wrote: > On Thu, Jun 26, 2014 at 10:55:33AM -0600, Eric Blake wrote: >> On 06/26/2014 12:13 AM, Hu Tao wrote: >>> We already have ROUND_UP but there are similar macros and ROUND_UP-li= ke >>> lines all around, replace them with ROUND_UP and clean up similar mac= ros. >>> >>> Signed-off-by: Hu Tao >>> --- >> >> All of these conversions are correct, so: >> Reviewed-by: Eric Blake >=20 > Thanks for review! >> tcg/ppc/tcg-target.c-#define FRAME_SIZE ((TCG_TARGET_CALL_STACK_OFFSET= \ >> tcg/ppc/tcg-target.c- + TCG_STATIC_CALL_ARGS_SIZE = \ >> tcg/ppc/tcg-target.c- + CPU_TEMP_BUF_SIZE = \ >> tcg/ppc/tcg-target.c- + REG_SAVE_SIZE = \ >> tcg/ppc/tcg-target.c- + TCG_TARGET_STACK_ALIGN - 1= ) \ >> tcg/ppc/tcg-target.c: & -TCG_TARGET_STACK_ALIGN) >=20 > How did you find this one? Your pattern below just shows the last line.= But the last line had the word ALIGN in it, so I looked at the context and found that it was indeed a rounding operation. >> before I quit looking for more. (I just manually read through >> git grep '[^&]& [~-]' >> which has a lot of noise for non-rounding uses, but definitely found >> some missed cases) Are you going to submit a v2? As this does not appear to be a bug fix, and today is hard freeze, this is probably 2.2 material. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HlqETrVeEx7vC3jH8jBvJ1k36UEb3OuMn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTsx1DAAoJEKeha0olJ0NqVmUIAIEsD5MYcBR8G4PBSgGgSfG1 uVOHvJmNWagfA+3XURzWt2UuW6EyA9CHBvWqrWIecCSAKwU4p+3/7tb3JjTnUmql CLz3kmr8Me5j1+zyotoEWUMTifmZ+goxviVXfElEFVhppqA7iS2F9XTCIhre/qPf uLRfk9b6PI/6xWQmUip4J8f7oKmljwdsSH7Mpxf2LKUvDGW2KfwWJVLkLW0XDRS2 hwzZwftSK4B/waThjgvPp0piP1VgRmygSpM1skOeMYwJNZh6M0JeQB4XTVdu+ASg 0yiqO3Z2TZUOiCQFlsxJadv+U3wMMbxo99J8kFzzm4w/SmSJ5ZScodj1UilO7Gg= =nP2O -----END PGP SIGNATURE----- --HlqETrVeEx7vC3jH8jBvJ1k36UEb3OuMn--