From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X26FG-0005eu-0H for qemu-devel@nongnu.org; Tue, 01 Jul 2014 18:09:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X26FB-0001MG-2M for qemu-devel@nongnu.org; Tue, 01 Jul 2014 18:09:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X26FA-0001M9-PH for qemu-devel@nongnu.org; Tue, 01 Jul 2014 18:09:40 -0400 Message-ID: <53B331A1.2020707@redhat.com> Date: Tue, 01 Jul 2014 16:09:37 -0600 From: Eric Blake MIME-Version: 1.0 References: <1404204537-5082-1-git-send-email-stefanha@redhat.com> <1404204537-5082-22-git-send-email-stefanha@redhat.com> In-Reply-To: <1404204537-5082-22-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1mfxpPDPXWhKQjrOBHd2CU1dtkwOF7ESP" Subject: Re: [Qemu-devel] [PULL for-2.1 21/24] block: add QAPI command to allow live backing file change List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Peter Maydell , Jeff Cody This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1mfxpPDPXWhKQjrOBHd2CU1dtkwOF7ESP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/01/2014 02:48 AM, Stefan Hajnoczi wrote: > From: Jeff Cody >=20 > This allows a user to make a live change to the backing file recorded i= n > an open image. >=20 > + > + /* final sanity check */ > + if (!bdrv_chain_contains(bs, image_bs)) { > + error_setg(errp, "'%s' and image file are not in the same chai= n", > + device); > + return; > + } Phooey - this is not bisectable, because bdrv_chain_contains was only introduced in 22/24. But it's already been pulled, so nothing we can do about it now. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --1mfxpPDPXWhKQjrOBHd2CU1dtkwOF7ESP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTszGhAAoJEKeha0olJ0Nqb8MH/RArSBOIBohTDHLuAacvLtBX hp4N1l6i08br1V35fdiiOHupxDOw8UAQhg0w30gbppVCtyZQ4P1TXlTkER8RTc7Q K7+3HA9zNzw0JwhINusNaqj19KSUy2R1au5RzxeAkgZIAkV/RWOjCKh5oQ5MvbBc Z7+EZyg69FoG7s+dmHAYPfx6FX3YnUIbq6B/LjY3j+K05kSFU09n0zo/InV0qlxg ZTPLdrwnSAp7MZuFj7LCpKXs5VHV4ZkTSq4WyU7jhqzzOLvPZqeSh6U7tY/RxW7E Lr/H4Y29vdX6hLRQ3EewhqCE/b/mx1bGK5CtWiye4ETzRFBn3NWWUzvPABhFfiw= =uOwN -----END PGP SIGNATURE----- --1mfxpPDPXWhKQjrOBHd2CU1dtkwOF7ESP--