From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2FmX-0000wa-JF for qemu-devel@nongnu.org; Wed, 02 Jul 2014 04:20:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X2FmP-0008L7-TX for qemu-devel@nongnu.org; Wed, 02 Jul 2014 04:20:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33549) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2FmP-0008Kr-L0 for qemu-devel@nongnu.org; Wed, 02 Jul 2014 04:20:37 -0400 Message-ID: <53B3C0CD.7030904@redhat.com> Date: Wed, 02 Jul 2014 10:20:29 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1403889855-5740-1-git-send-email-armbru@redhat.com> <1403889855-5740-3-git-send-email-armbru@redhat.com> <53B2C8C0.6030303@gmail.com> <53B2E5D9.9040606@redhat.com> <87ha30l0l1.fsf@blackfin.pond.sub.org> In-Reply-To: <87ha30l0l1.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2.1 2/3] blockjob: Fix recent BLOCK_JOB_ERROR regression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, lcapitulino@redhat.com, Wenchao Xia , stefanha@redhat.com, qemu-devel@nongnu.org Il 02/07/2014 08:46, Markus Armbruster ha scritto: >> > I think consistency between BLOCK_IO_ERROR and BLOCK_JOB_ERROR is >> > better. > Moreover, BlockdevOnError's enospc is meaningless here. > >> > Let's fix the BlockErrorAction documentation instead. > I didn't quite understand what's wrong with it; I expect a patch will > enlighten me :) For BLOCK_JOB_ERROR, "stop" means the job is paused rather than the VM. I have more documentation work queued for hard freeze, so you or Wenchao should feel free to submit this bit too. ;) Paolo