From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2FpA-00052R-DH for qemu-devel@nongnu.org; Wed, 02 Jul 2014 04:23:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X2Fp2-000109-Vf for qemu-devel@nongnu.org; Wed, 02 Jul 2014 04:23:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2Fp2-0000zx-Na for qemu-devel@nongnu.org; Wed, 02 Jul 2014 04:23:20 -0400 Message-ID: <53B3C172.30606@redhat.com> Date: Wed, 02 Jul 2014 10:23:14 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1403889855-5740-1-git-send-email-armbru@redhat.com> <1403889855-5740-2-git-send-email-armbru@redhat.com> <53B2EB0F.2050402@redhat.com> <53B2EBA0.8080108@redhat.com> <8738ekl05m.fsf@blackfin.pond.sub.org> In-Reply-To: <8738ekl05m.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, wenchaoqemu@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, stefanha@redhat.com Il 02/07/2014 08:55, Markus Armbruster ha scritto: >> > I think this fixes itself automatically if you use >> > rerror=stop/werror=stop on block jobs. At least that was part of the >> > design, whether the implementation gets it right I cannot say without >> > looking at the code more carefully. > What if an underlying device doesn't support [rw]error=stop? Not all > do... Then the "fix" is to add support to the underlying device. IDE, SCSI and virtio-blk (plus virtio-scsi via SCSI of course) are covered; the main one that's left out is SD. Paolo