From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: wenchaoqemu@gmail.com, qemu-devel@nongnu.org,
Markus Armbruster <armbru@redhat.com>,
lcapitulino@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression
Date: Wed, 02 Jul 2014 10:59:34 +0200 [thread overview]
Message-ID: <53B3C9F6.7000005@redhat.com> (raw)
In-Reply-To: <20140702084416.GB5996@noname.str.redhat.com>
Il 02/07/2014 10:44, Kevin Wolf ha scritto:
>> > Then the "fix" is to add support to the underlying device. IDE,
>> > SCSI and virtio-blk (plus virtio-scsi via SCSI of course) are
>> > covered; the main one that's left out is SD.
> Isn't block job rerror/werror completely independent from the guest
> device using the same BDS? They are different users, so if we somehow
> coupled them, that would be a design problem (which I think we were
> careful enough to avoid).
It is independent, but for some reason rerror/werror cannot be used on
block jobs unless iostatus is enabled on the source BDS too. Off-hand I
don't remember why.
Paolo
next prev parent reply other threads:[~2014-07-02 8:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 17:24 [Qemu-devel] [PATCH v2 2.1 0/3] Fix two recent event regressions Markus Armbruster
2014-06-27 17:24 ` [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression Markus Armbruster
2014-07-01 17:08 ` Eric Blake
2014-07-01 17:10 ` Paolo Bonzini
2014-07-02 6:55 ` Markus Armbruster
2014-07-02 8:23 ` Paolo Bonzini
2014-07-02 8:44 ` Kevin Wolf
2014-07-02 8:59 ` Paolo Bonzini [this message]
2014-07-02 14:58 ` Markus Armbruster
2014-07-02 15:03 ` Paolo Bonzini
2014-07-02 16:05 ` Eric Blake
2014-07-03 7:19 ` Markus Armbruster
2014-07-03 9:25 ` Paolo Bonzini
2014-07-03 15:06 ` Markus Armbruster
2014-06-27 17:24 ` [Qemu-devel] [PATCH v2 2.1 2/3] blockjob: Fix recent BLOCK_JOB_ERROR regression Markus Armbruster
2014-07-01 14:42 ` Wenchao Xia
2014-07-01 16:46 ` Paolo Bonzini
2014-07-02 6:46 ` Markus Armbruster
2014-07-02 8:20 ` Paolo Bonzini
2014-06-27 17:24 ` [Qemu-devel] [PATCH v2 2.1 3/3] docs/qmp: Fix documentation of BLOCK_JOB_READY to match code Markus Armbruster
2014-06-27 17:42 ` Luiz Capitulino
2014-07-01 17:12 ` Eric Blake
2014-07-02 6:49 ` Markus Armbruster
2014-07-02 8:48 ` Kevin Wolf
2014-07-02 7:55 ` Paolo Bonzini
2014-06-27 18:37 ` [Qemu-devel] [PATCH v2 2.1 0/3] Fix two recent event regressions Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B3C9F6.7000005@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wenchaoqemu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).