From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41574)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X2GOP-0002r0-B7
	for qemu-devel@nongnu.org; Wed, 02 Jul 2014 04:59:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X2GOJ-0004PY-7K
	for qemu-devel@nongnu.org; Wed, 02 Jul 2014 04:59:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9185)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X2GOI-0004PN-VS
	for qemu-devel@nongnu.org; Wed, 02 Jul 2014 04:59:47 -0400
Message-ID: <53B3C9F6.7000005@redhat.com>
Date: Wed, 02 Jul 2014 10:59:34 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1403889855-5740-1-git-send-email-armbru@redhat.com>
	<1403889855-5740-2-git-send-email-armbru@redhat.com>
	<53B2EB0F.2050402@redhat.com> <53B2EBA0.8080108@redhat.com>
	<8738ekl05m.fsf@blackfin.pond.sub.org> <53B3C172.30606@redhat.com>
	<20140702084416.GB5996@noname.str.redhat.com>
In-Reply-To: <20140702084416.GB5996@noname.str.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent
 BLOCK_JOB_READY regression
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: wenchaoqemu@gmail.com, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, lcapitulino@redhat.com, stefanha@redhat.com

Il 02/07/2014 10:44, Kevin Wolf ha scritto:
>> > Then the "fix" is to add support to the underlying device.  IDE,
>> > SCSI and virtio-blk (plus virtio-scsi via SCSI of course) are
>> > covered; the main one that's left out is SD.
> Isn't block job rerror/werror completely independent from the guest
> device using the same BDS? They are different users, so if we somehow
> coupled them, that would be a design problem (which I think we were
> careful enough to avoid).

It is independent, but for some reason rerror/werror cannot be used on 
block jobs unless iostatus is enabled on the source BDS too.  Off-hand I 
don't remember why.

Paolo