From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51651)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X2Gwi-0008VI-Eg
	for qemu-devel@nongnu.org; Wed, 02 Jul 2014 05:35:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X2Gwc-0008Q7-Sq
	for qemu-devel@nongnu.org; Wed, 02 Jul 2014 05:35:20 -0400
Received: from mail-qa0-x22f.google.com ([2607:f8b0:400d:c00::22f]:48227)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X2Gwc-0008Q2-P1
	for qemu-devel@nongnu.org; Wed, 02 Jul 2014 05:35:14 -0400
Received: by mail-qa0-f47.google.com with SMTP id hw13so8773936qab.34
	for <qemu-devel@nongnu.org>; Wed, 02 Jul 2014 02:35:14 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53B3D24E.2020205@redhat.com>
Date: Wed, 02 Jul 2014 11:35:10 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1404288324-16766-1-git-send-email-mrezanin@redhat.com>
In-Reply-To: <1404288324-16766-1-git-send-email-mrezanin@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Enforce stack protector usage
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: mrezanin@redhat.com, qemu-devel@nongnu.org

Il 02/07/2014 10:05, mrezanin@redhat.com ha scritto:
> From: Miroslav Rezanina <mrezanin@redhat.com>
>
> If --enable-stack-protector is used is used, configure script try to use
> --fstack-protector-strong. In case it's not supported, --fstack-protector-all
> is enabled. If both protectors are not supported, configure does not use
> any protector at all without any notification.
>
> This patch reports error when user requests stack protector to be used and
> both protector modes are not supported. Behavior is not changed in case
> user do not use any of --enable-stack-protector/--disable-stack-protector.
>
> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
> ---
>  configure | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/configure b/configure
> index 7dd43fd..b880954 100755
> --- a/configure
> +++ b/configure
> @@ -1491,6 +1491,7 @@ done
>
>  if test "$stack_protector" != "no" ; then
>    gcc_flags="-fstack-protector-strong -fstack-protector-all"
> +  sp_on=0
>    for flag in $gcc_flags; do
>      # We need to check both a compile and a link, since some compiler
>      # setups fail only on a .c->.o compile and some only at link time
> @@ -1498,9 +1499,15 @@ if test "$stack_protector" != "no" ; then
>         compile_prog "-Werror $flag" ""; then
>        QEMU_CFLAGS="$QEMU_CFLAGS $flag"
>        LIBTOOLFLAGS="$LIBTOOLFLAGS -Wc,$flag"
> +      sp_on=1
>        break
>      fi
>    done
> +  if test "$stack_protector" == "yes" ; then
> +    if test "$sp_on" == "0" ; then
> +      error_exit "Stack protector not supported"
> +    fi
> +  fi
>  fi
>
>  # Workaround for http://gcc.gnu.org/PR55489.  Happens with -fPIE/-fPIC and
>

Thanks, queued for -rc1.

Paolo