From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37383)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1X2Ma2-0002LZ-Ac
	for qemu-devel@nongnu.org; Wed, 02 Jul 2014 11:36:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1X2MZs-0005Ro-8M
	for qemu-devel@nongnu.org; Wed, 02 Jul 2014 11:36:18 -0400
Message-ID: <53B426E4.7020903@suse.de>
Date: Wed, 02 Jul 2014 17:36:04 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1404251378-5242-1-git-send-email-agraf@suse.de>
	<1404251378-5242-5-git-send-email-agraf@suse.de>
	<53B3A76C.4010201@redhat.com>
In-Reply-To: <53B3A76C.4010201@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/6] sysbus: Make devices spawnable via
	-device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-ppc@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, eric.auger@linaro.org, qemu-devel@nongnu.org, sean.stalley@intel.com, afaerber@suse.de


On 02.07.14 08:32, Paolo Bonzini wrote:
> Il 01/07/2014 23:49, Alexander Graf ha scritto:
>> +
>> +static void machine_init_notify(Notifier *notifier, void *data)
>> +{
>> +    Object *machine = qdev_get_machine();
>> +    Object *container;
>> +
>> +    if (object_property_find(machine, "has-dynamic-sysbus", NULL)) {
>> +        /* Our machine can handle dynamic sysbus devices, we're all 
>> good */
>> +        return;
>> +    }
>
> Does it need to be a property, or can it simply be a bool in 
> MachineClass?

Sure - I'll change it to be a bool in MachineClass and QEMUMachine (I 
really don't want to have the qom-machinification also as part of this 
patch set)


Alex