From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2N1z-0006T2-2t for qemu-devel@nongnu.org; Wed, 02 Jul 2014 12:05:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X2N1u-0007mW-ER for qemu-devel@nongnu.org; Wed, 02 Jul 2014 12:05:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40017) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2N1u-0007m1-72 for qemu-devel@nongnu.org; Wed, 02 Jul 2014 12:05:06 -0400 Message-ID: <53B42DAE.2010000@redhat.com> Date: Wed, 02 Jul 2014 10:05:02 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403889855-5740-1-git-send-email-armbru@redhat.com> <1403889855-5740-2-git-send-email-armbru@redhat.com> <53B2EB0F.2050402@redhat.com> <53B2EBA0.8080108@redhat.com> <8738ekl05m.fsf@blackfin.pond.sub.org> <53B3C172.30606@redhat.com> <87fvijyfh9.fsf@blackfin.pond.sub.org> <53B41F33.7080904@redhat.com> In-Reply-To: <53B41F33.7080904@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Hntpfq9J6a04LanInja4opb57q1EO7RgB" Subject: Re: [Qemu-devel] [PATCH v2 2.1 1/3] blockjob: Fix recent BLOCK_JOB_READY regression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Markus Armbruster Cc: kwolf@redhat.com, qemu-devel@nongnu.org, wenchaoqemu@gmail.com, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Hntpfq9J6a04LanInja4opb57q1EO7RgB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/02/2014 09:03 AM, Paolo Bonzini wrote: >>>> What if an underlying device doesn't support [rw]error=3Dstop? Not = all >>>> do... >>> >>> Then the "fix" is to add support to the underlying device. IDE, SCSI= >>> and virtio-blk (plus virtio-scsi via SCSI of course) are covered; >> >> Where "covered" means "device model calls bdrv_error_action() somewher= e" >> rather than "device model calls bdrv_error_action() exactly when it >> should". >> >> Case in point: SCSI calls it when UNMAP fails, but IDE doesn't call it= >> when TRIM fails. IDE and virtio-blk call it for I/O beyond the end of= >> the medium, but SCSI doesn't. >> >> This is of course fixable. I'm working on it. >> >>> the= >>> main one that's left out is SD. >> >> Qdevified devices with a qdev_prop_drive: isa-fdc, sysbus-fdc, >> SUNW,fdtwo, nand, onenand, cfi.pflash01, cfi.pflash02, spapr-nvram, >> scsi-generic, nvme. SD isn't in this list, because it still hasn't be= en >> qdevified. There may be more. >=20 > I think there is a page with unfinished transition. Can you add this o= ne? Listed: http://wiki.qemu.org/CodeTransitions#Reliable_block_job_polling --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Hntpfq9J6a04LanInja4opb57q1EO7RgB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTtC2uAAoJEKeha0olJ0NqoOEH/2Nzq8XtflvFszKCuXfLQM11 MrF0yRJ5TVJMAM7p/d3qeMt/tNw/dHGbUTrEDy1zl4iHXz8/lkL4uBFedAxsfEM3 WxntbyK1rSoAzecKOzZLvJ93Y85tRQVfWsFIZ6L9HVN25HjMvtpSmsWb4DtLvhJe wXj536NTCns4Oo0UDymJCIwAyZK24ngHiviDBXbCVkODpsydfbc0cFwndmsXohS8 He48YRpUKwoCJdw8ymXTYyYKA8lxjmAMalosXx4J7Xh+iupAPIavCC3v8x3fmru1 RYfG0gS8i6HGn2gDaOJtQSPA5SHuDShB94I1HsG5RyfaFFegkWpXk7ExxRllJPY= =3ACS -----END PGP SIGNATURE----- --Hntpfq9J6a04LanInja4opb57q1EO7RgB--