From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, Le Tan <tamlokveer@gmail.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, jan.kiszka@web.de,
qemu-devel@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH] ahci: map memory via device's address space instead of address_space_memory
Date: Thu, 03 Jul 2014 10:47:27 +0200 [thread overview]
Message-ID: <53B5189F.4020909@redhat.com> (raw)
In-Reply-To: <20140703082852.GC20580@redhat.com>
Il 03/07/2014 10:28, Michael S. Tsirkin ha scritto:
> On Thu, Jul 03, 2014 at 04:26:27PM +0800, Le Tan wrote:
>> In map_page() in hw/ide/ahci.c, replace cpu_physical_memory_map() and
>> cpu_physical_memory_unmap() with dma_memory_map() and dma_memory_unmap(),
>> because ahci devices should not access memory directly but via their address
>> space. Add an AddressSpace parameter to map_page(). In order to call
>> map_page(), we should pass the AHCIState.as as the AddressSpace argument.
>>
>> Signed-off-by: Le Tan <tamlokveer@gmail.com>
>
> Makes sense
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
I think this is ok for 2.1 as well.
Paolo
next prev parent reply other threads:[~2014-07-03 8:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 8:26 [Qemu-devel] [PATCH] ahci: map memory via device's address space instead of address_space_memory Le Tan
2014-07-03 8:28 ` Michael S. Tsirkin
2014-07-03 8:47 ` Paolo Bonzini [this message]
2014-07-06 6:15 ` [Qemu-devel] for-2.1 (was Re: [PATCH] ahci: map memory via device's address space instead of address_space_memory) Michael S. Tsirkin
2014-07-06 13:45 ` Paolo Bonzini
2014-07-07 8:23 ` Stefan Hajnoczi
2014-07-03 8:43 ` [Qemu-devel] [PATCH] ahci: map memory via device's address space instead of address_space_memory Jan Kiszka
2014-07-03 9:41 ` Paolo Bonzini
2014-07-03 10:11 ` Michael S. Tsirkin
2014-07-03 10:02 ` Michael S. Tsirkin
2014-07-03 16:45 ` Jan Kiszka
2014-07-03 20:30 ` Michael S. Tsirkin
2014-07-04 5:26 ` Jan Kiszka
2014-07-06 5:58 ` Michael S. Tsirkin
2014-07-07 8:23 ` Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2015-02-26 5:13 Jordan Hargrave
2015-02-26 14:45 ` Stefan Hajnoczi
2015-02-26 21:31 ` Jordan Hargrave
2015-02-26 22:02 ` Paolo Bonzini
2015-03-09 22:42 ` John Snow
2015-02-26 22:31 ` John Snow
[not found] ` <CAC1AzdcoEUtiGyCSXSf0bniUvQZ9tTeX2Vc9KQUyBfQxFV+JFg@mail.gmail.com>
2015-03-02 16:37 ` John Snow
2015-03-12 17:41 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B5189F.4020909@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=jan.kiszka@web.de \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=tamlokveer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).