From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2hXj-0007CZ-Ib for qemu-devel@nongnu.org; Thu, 03 Jul 2014 09:59:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X2hXe-0004nK-Ai for qemu-devel@nongnu.org; Thu, 03 Jul 2014 09:59:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2hXe-0004mv-2P for qemu-devel@nongnu.org; Thu, 03 Jul 2014 09:59:14 -0400 Message-ID: <53B561AE.3050307@redhat.com> Date: Thu, 03 Jul 2014 07:59:10 -0600 From: Eric Blake MIME-Version: 1.0 References: <1404395521-11158-1-git-send-email-stefanha@redhat.com> <1404395521-11158-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1404395521-11158-2-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DSeS1DOHEXSkgHpuDDvPn9iWf9HxVxM3j" Subject: Re: [Qemu-devel] [PATCH 1/2] coroutine: make pool size dynamic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , ming.lei@canonical.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DSeS1DOHEXSkgHpuDDvPn9iWf9HxVxM3j Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/03/2014 07:52 AM, Stefan Hajnoczi wrote: > Allow coroutine users to adjust the pool size. For example, if the > guest has multiple emulated disk drives we should keep around more > coroutines. >=20 > Signed-off-by: Stefan Hajnoczi > --- > include/block/coroutine.h | 11 +++++++++++ > qemu-coroutine.c | 25 +++++++++++++++++++------ > 2 files changed, 30 insertions(+), 6 deletions(-) >=20 > + > +void qemu_coroutine_adjust_pool_size(int n) > +{ > + qemu_mutex_lock(&pool_lock); > + > + pool_max_size +=3D n; Where do you check that this doesn't fall below a bare-minimum acceptable level? Is it worth assert(pool_max_size >=3D 64)? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DSeS1DOHEXSkgHpuDDvPn9iWf9HxVxM3j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTtWGuAAoJEKeha0olJ0Nq1JoH/1S0txkAXTsXn4Ds8QQWykML E3VYTYdzdLBpoCcnBnQfFqIm5ciB8BcFsEWOHQtbGxe5w7QsevSOOfegoJ9NNVfK r5a/xi47LkrOUv9jOA8LEhIYe2/AsGtgbKicLwDeyvfh/ilHN8MFPeJg3FXGY1Jh nnrPcW3dFyH9irb37aSGVqZ9ETO6v9EpZ5QzJSVHElvX1LjMKFV1WizKtt92bd9O UDnO13SlaFQnGygEVf1Ua8erx5SF8ChZKonCHaW4k3u8P1aMhQ3f1+AXEM3XL8gh RXJsZq6eauoPADIYsKfSk2h4+CdVsRuLyRfCHy42oQMq2z4L0S6CUspaBATDfFU= =cqRn -----END PGP SIGNATURE----- --DSeS1DOHEXSkgHpuDDvPn9iWf9HxVxM3j--