From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47619)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X2jUR-0005iv-Q0
	for qemu-devel@nongnu.org; Thu, 03 Jul 2014 12:04:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X2jUL-0008C1-KU
	for qemu-devel@nongnu.org; Thu, 03 Jul 2014 12:04:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54126)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X2jUL-0008Bt-An
	for qemu-devel@nongnu.org; Thu, 03 Jul 2014 12:03:57 -0400
Message-ID: <53B57EE4.2080100@redhat.com>
Date: Thu, 03 Jul 2014 18:03:48 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <CAJSP0QURqgPR40UomVFMjKNuRj6mYENARs8kn5QFT7Ckf3QQ0w@mail.gmail.com>
In-Reply-To: <CAJSP0QURqgPR40UomVFMjKNuRj6mYENARs8kn5QFT7Ckf3QQ0w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] virtio-blk-pci hot unplug broken in QEMU 2.0-rc0
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel <qemu-devel@nongnu.org>
Cc: Peter Maydell <peter.maydell@linaro.org>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, "Michael S. Tsirkin" <mst@redhat.com>

Il 03/07/2014 18:02, Stefan Hajnoczi ha scritto:
> Hot unplug is broken in qemu.git/master
> (92259b7f434b382fc865d1f65f7d5adeed295749 aka 2.0-rc0).
>
> It can be bisected but I won't be able to do that today.  Here are the
> details if anyone has ideas:

Most likely my fault (memory region QOMification).

Paolo

> $ x86_64-softmmu/qemu-system-x86_64 -enable-kvm -cpu host -m 1024
> -drive if=virtio,cache=none,file=test.img
> (qemu) drive_add 0 if=none,id=drive0,file=test.qcow2,format=qcow2
> (qemu) device_add virtio-blk-pci,drive=drive0,id=virtio-blk-pci0
> (qemu) device_del virtio-blk-pci0
> ERROR:qom/object.c:725:object_unref: assertion failed: (obj->ref > 0)
>
> #5  0x00007fd4b0610959 in object_unref (obj=0x7fd4b27e29f8) at qom/object.c:725
> #6  0x00007fd4b044280a in memory_region_del_subregion
> (mr=0x7fd4b25402c0, subregion=0x7fd4b27e29f8) at
> /home/stefanha/qemu/memory.c:1702
> #7  0x00007fd4b05bfdcf in pci_unregister_io_regions
> (pci_dev=0x7fd4b27e25e0) at hw/pci/pci.c:894
> #8  pci_unregister_device (dev=<optimized out>) at hw/pci/pci.c:905
> #9  0x00007fd4b0570a84 in device_unrealize (dev=0x7fd4b27e25e0,
> errp=0x7fd49cbfd8b0) at hw/core/qdev.c:196
> #10 0x00007fd4b0571f3a in device_set_realized (obj=<optimized out>,
> value=<optimized out>, errp=0x0) at hw/core/qdev.c:885
> #11 0x00007fd4b060fb8e in property_set_bool (obj=0x7fd4b27e25e0,
> v=<optimized out>, opaque=0x7fd4b2610a70, name=<optimized out>,
> errp=0x0)
>     at qom/object.c:1473
> #12 0x00007fd4b06123f7 in object_property_set_qobject
> (obj=obj@entry=0x7fd4b27e25e0, value=value@entry=0x7fd490021140,
>     name=name@entry=0x7fd4b06d70d0 "realized", errp=errp@entry=0x0) at
> qom/qom-qobject.c:24
> #13 0x00007fd4b0611010 in object_property_set_bool
> (obj=obj@entry=0x7fd4b27e25e0, value=value@entry=false,
>     name=name@entry=0x7fd4b06d70d0 "realized", errp=errp@entry=0x0) at
> qom/object.c:888
> #14 0x00007fd4b05707db in device_unparent (obj=0x7fd4b27e25e0) at
> hw/core/qdev.c:1000
> #15 0x00007fd4b0610c85 in object_unparent (obj=0x7fd4b27e25e0) at
> qom/object.c:396
> #16 0x00007fd4b0550776 in acpi_pcihp_eject_slot (s=<optimized out>,
> bsel=<optimized out>, slots=<optimized out>) at hw/acpi/pcihp.c:139
>