From: Max Reitz <mreitz@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>, Kevin Wolf <kwolf@redhat.com>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RFC v11 6/6] qcow2: Add falloc and full preallocation option
Date: Thu, 03 Jul 2014 22:35:27 +0200 [thread overview]
Message-ID: <53B5BE8F.7000100@redhat.com> (raw)
In-Reply-To: <6583fb5f97a6d173be3865d2794ceb3cccf7c013.1404287261.git.hutao@cn.fujitsu.com>
On 02.07.2014 10:17, Hu Tao wrote:
> This adds preallocation=falloc and preallocation=full mode to qcow2
> image creation.
>
> preallocation=full allocates disk space by writing zeros to disk to
> ensure disk space in any cases.
>
> preallocation=falloc likes preallocation=full, but allocates disk space
> by posix_fallocate().
>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
> block/qcow2.c | 29 ++++++++++++++++++++++++-
> tests/qemu-iotests/082.out | 54 +++++++++++++++++++++++-----------------------
> 2 files changed, 55 insertions(+), 28 deletions(-)
Ah, I missed something: You'll need to fix the output of test 049 as
well ("Invalid preallocation mode: '1234'" -> "invalid parameter value:
1234").
Max
prev parent reply other threads:[~2014-07-03 20:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 8:17 [Qemu-devel] [PATCH RFC v11 0/6] qcow2, raw: add preallocation=full and preallocation=falloc Hu Tao
2014-07-02 8:17 ` [Qemu-devel] [PATCH RFC v11 1/6] block: round up file size to nearest sector Hu Tao
2014-07-02 13:29 ` [Qemu-devel] [PATCH for-2.1? " Eric Blake
2014-07-02 8:17 ` [Qemu-devel] [PATCH RFC v11 2/6] raw, qcow2: don't convert file size to sector size Hu Tao
2014-07-03 20:28 ` Eric Blake
2014-07-02 8:17 ` [Qemu-devel] [PATCH RFC v11 3/6] rename parse_enum_option to qapi_enum_parse and make it public Hu Tao
2014-07-03 20:29 ` Eric Blake
2014-07-02 8:17 ` [Qemu-devel] [PATCH RFC v11 4/6] qapi: introduce PreallocMode and a new PreallocMode full Hu Tao
2014-07-03 20:00 ` Max Reitz
2014-07-02 8:17 ` [Qemu-devel] [PATCH RFC v11 5/6] raw-posix: Add falloc and full preallocation option Hu Tao
2014-07-03 20:10 ` Max Reitz
2014-07-02 8:17 ` [Qemu-devel] [PATCH RFC v11 6/6] qcow2: " Hu Tao
2014-07-03 20:30 ` Max Reitz
2014-07-03 20:35 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B5BE8F.7000100@redhat.com \
--to=mreitz@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).