From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43387)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1X2njF-000620-C6
	for qemu-devel@nongnu.org; Thu, 03 Jul 2014 16:35:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1X2njC-00070n-Pa
	for qemu-devel@nongnu.org; Thu, 03 Jul 2014 16:35:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20129)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1X2njC-00070i-HA
	for qemu-devel@nongnu.org; Thu, 03 Jul 2014 16:35:34 -0400
Message-ID: <53B5BE8F.7000100@redhat.com>
Date: Thu, 03 Jul 2014 22:35:27 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <cover.1404287261.git.hutao@cn.fujitsu.com>
	<6583fb5f97a6d173be3865d2794ceb3cccf7c013.1404287261.git.hutao@cn.fujitsu.com>
In-Reply-To: <6583fb5f97a6d173be3865d2794ceb3cccf7c013.1404287261.git.hutao@cn.fujitsu.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC v11 6/6] qcow2: Add falloc and full
 preallocation option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hu Tao <hutao@cn.fujitsu.com>, Kevin Wolf <kwolf@redhat.com>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On 02.07.2014 10:17, Hu Tao wrote:
> This adds preallocation=falloc and preallocation=full mode to qcow2
> image creation.
>
> preallocation=full allocates disk space by writing zeros to disk to
> ensure disk space in any cases.
>
> preallocation=falloc likes preallocation=full, but allocates disk space
> by posix_fallocate().
>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
>   block/qcow2.c              | 29 ++++++++++++++++++++++++-
>   tests/qemu-iotests/082.out | 54 +++++++++++++++++++++++-----------------------
>   2 files changed, 55 insertions(+), 28 deletions(-)

Ah, I missed something: You'll need to fix the output of test 049 as 
well ("Invalid preallocation mode: '1234'" -> "invalid parameter value: 
1234").

Max