From: Paolo Bonzini <pbonzini@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>, Eric Blake <eblake@redhat.com>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
Igor Mammedov <imammedo@redhat.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for 2.1 2/2] memory-backend-file: improve error handling
Date: Fri, 04 Jul 2014 09:47:43 +0200 [thread overview]
Message-ID: <53B65C1F.5030304@redhat.com> (raw)
In-Reply-To: <20140704074320.GB2176@G08FNSTD100614.fnst.cn.fujitsu.com>
Il 04/07/2014 09:43, Hu Tao ha scritto:
> The memory size is rounded up to hpagesize when allocating memory, we
> can waste at most hpagesize-1 bytes memory. I don't think it's a
> problem.
>
> In the other side, do you think we should give an error in the case like
> -object memory-backend-ram,size=1111M(given 2M hpagesize)?
I think for gb pages it can make sense to waste a little memory (or even
not so little, like if you have a 2.5 GB guest).
Paolo
next prev parent reply other threads:[~2014-07-04 7:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 6:10 [Qemu-devel] [PATCH for 2.1 0/2] bug fixs for memory backend Hu Tao
2014-07-03 6:10 ` [Qemu-devel] [PATCH for 2.1 1/2] memory: introduce memory_region_init_ram_nofail() and memory_region_init_ram_ptr_nofail() Hu Tao
2014-07-03 6:51 ` Michael S. Tsirkin
2014-07-04 2:50 ` Hu Tao
2014-07-03 6:10 ` [Qemu-devel] [PATCH for 2.1 2/2] memory-backend-file: improve error handling Hu Tao
2014-07-03 12:33 ` Eric Blake
2014-07-04 2:56 ` Hu Tao
2014-07-04 4:05 ` Eric Blake
2014-07-04 7:43 ` Hu Tao
2014-07-04 7:47 ` Paolo Bonzini [this message]
2014-07-06 6:42 ` Michael S. Tsirkin
2014-07-07 2:23 ` Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B65C1F.5030304@redhat.com \
--to=pbonzini@redhat.com \
--cc=eblake@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).