From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47626)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1X38WU-0006kM-9b
	for qemu-devel@nongnu.org; Fri, 04 Jul 2014 14:47:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1X38WO-0005tL-3c
	for qemu-devel@nongnu.org; Fri, 04 Jul 2014 14:47:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56246)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1X38WN-0005qc-Rc
	for qemu-devel@nongnu.org; Fri, 04 Jul 2014 14:47:44 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s64Ilg8C032428
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 4 Jul 2014 14:47:42 -0400
Message-ID: <53B6F6CD.4060200@redhat.com>
Date: Fri, 04 Jul 2014 14:47:41 -0400
From: Cole Robinson <crobinso@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] bootindex dropped from -device virtio-blk, ? output,
	upsets libvirt
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: Stefan Hajnoczi <stefanha@redhat.com>

Hi all,

qemu-2.1-rc0 upsets some of libvirt's qemu feature introspection, the example
I hit is with bootindex support. qemu -device virtio-blk,? no longer lists the
bootindex= property, so libvirt thinks that qemu doesn't support it, and fails
to launch a VM with per-device boot order configuration.

The qemu culprit is:

commit caffdac363801cd2cf2bf01ad013a8c1e1e43800
Author: Stefan Hajnoczi <stefanha@redhat.com>
Date:   Wed Jun 18 17:58:33 2014 +0800

    virtio-blk: use aliases instead of duplicate qdev properties

These alias properties aren't printed in qdev-monitor.c:qdev_device_help. In
fact I'm not sure if aliases are even accessible in that function, since the
they are only registered at instance init time, and I don't think any device
has actually been initialized when qdev_device_help is called. That's my
reading anyways.

Thoughts?

Thanks,
Cole