From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38208)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X3Mfo-0000NI-HS
	for qemu-devel@nongnu.org; Sat, 05 Jul 2014 05:54:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X3Mff-0003Cc-Ai
	for qemu-devel@nongnu.org; Sat, 05 Jul 2014 05:54:24 -0400
Received: from mail-qc0-x229.google.com ([2607:f8b0:400d:c01::229]:41215)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X3Mff-0003CV-6O
	for qemu-devel@nongnu.org; Sat, 05 Jul 2014 05:54:15 -0400
Received: by mail-qc0-f169.google.com with SMTP id c9so2194720qcz.14
	for <qemu-devel@nongnu.org>; Sat, 05 Jul 2014 02:54:14 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53B7CB42.5060609@redhat.com>
Date: Sat, 05 Jul 2014 11:54:10 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1404503074-6381-1-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1404503074-6381-1-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.1] target-i386: Add
 "kvmclock-stable-bit" feature bit name
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, kvm@vger.kernel.org
Cc: Igor Mammedov <imammedo@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>

Il 04/07/2014 21:44, Eduardo Habkost ha scritto:
> KVM_FEATURE_CLOCKSOURCE_STABLE_BIT is enabled by default and supported
> by KVM. But not having a name defined makes QEMU treat it as an unknown
> and unmigratable feature flag (as any unknown feature may possibly
> require state to be migrated), and disable it by default on "-cpu host".
>
> As a side-effect, the new name also makes the flag configurable,
> allowing the user to disable it (which may be useful for testing or for
> compatibility with old kernels).
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target-i386/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 45c662d..6d008ab 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -241,7 +241,7 @@ static const char *kvm_feature_name[] = {
>      NULL, NULL, NULL, NULL,
>      NULL, NULL, NULL, NULL,
>      NULL, NULL, NULL, NULL,
> -    NULL, NULL, NULL, NULL,
> +    "kvmclock-stable-bit", NULL, NULL, NULL,
>      NULL, NULL, NULL, NULL,
>  };
>
>

Applied to uq/master, thanks.

Paolo