From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3VUo-0006v8-EZ for qemu-devel@nongnu.org; Sat, 05 Jul 2014 15:19:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3VUh-0005ME-31 for qemu-devel@nongnu.org; Sat, 05 Jul 2014 15:19:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3VUg-0005M9-Ri for qemu-devel@nongnu.org; Sat, 05 Jul 2014 15:19:31 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s65JJTxx023951 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 5 Jul 2014 15:19:30 -0400 Message-ID: <53B84FBD.3000204@redhat.com> Date: Sat, 05 Jul 2014 21:19:25 +0200 From: Max Reitz MIME-Version: 1.0 References: <1404489305-8750-1-git-send-email-kwolf@redhat.com> <1404489305-8750-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1404489305-8750-2-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] block: Make qiov match the request size until EOF List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: stefanha@redhat.com On 04.07.2014 17:55, Kevin Wolf wrote: > If a read request goes across EOF, the block driver sees a shortened > request that stops at EOF (the rest is memsetted in block.c), however > the original qiov was used for this request. > > This patch makes the qiov size match the request size, avoiding a > potential buffer overflow in raw-posix. > > Signed-off-by: Kevin Wolf > --- > block.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz