From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 4/4] block: Assert qiov length matches request length
Date: Sat, 05 Jul 2014 22:14:01 +0200 [thread overview]
Message-ID: <53B85C89.4070306@redhat.com> (raw)
In-Reply-To: <1404489305-8750-5-git-send-email-kwolf@redhat.com>
On 04.07.2014 17:55, Kevin Wolf wrote:
> At least raw-posix relies on this because it can allocate bounce buffers
> based on the request length, but access it using all of the qiov entries
> later.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block.c | 2 ++
> block/raw-posix.c | 15 +++++++++++----
> 2 files changed, 13 insertions(+), 4 deletions(-)
Somehow I'm not sure whether I want to give my R-b to this, in case one
of these assertions should fail. ;-)
But they look correct (considering QIO vectors now have to be just as
long as the request), so:
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2014-07-05 20:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 15:55 [Qemu-devel] [PATCH 0/4] block: Fix qiov sizes Kevin Wolf
2014-07-04 15:55 ` [Qemu-devel] [PATCH 1/4] block: Make qiov match the request size until EOF Kevin Wolf
2014-07-05 19:19 ` Max Reitz
2014-07-04 15:55 ` [Qemu-devel] [PATCH 2/4] qcow2: Make qiov match request size until backing file EOF Kevin Wolf
2014-07-05 19:37 ` Max Reitz
2014-07-04 15:55 ` [Qemu-devel] [PATCH 3/4] qed: " Kevin Wolf
2014-07-05 20:06 ` Max Reitz
2014-07-08 13:07 ` Kevin Wolf
2014-07-08 13:14 ` [Qemu-devel] [PATCH v2 for-2.1 " Kevin Wolf
2014-07-09 1:52 ` Eric Blake
2014-07-04 15:55 ` [Qemu-devel] [PATCH 4/4] block: Assert qiov length matches request length Kevin Wolf
2014-07-05 20:14 ` Max Reitz [this message]
2014-07-07 15:05 ` [Qemu-devel] [PATCH for-2.1 0/4] block: Fix qiov sizes Eric Blake
2014-07-09 11:34 ` [Qemu-devel] [PATCH " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B85C89.4070306@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).