From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3WLZ-0005nB-Tl for qemu-devel@nongnu.org; Sat, 05 Jul 2014 16:14:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3WLT-0006sg-QX for qemu-devel@nongnu.org; Sat, 05 Jul 2014 16:14:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52264) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3WLT-0006sc-IU for qemu-devel@nongnu.org; Sat, 05 Jul 2014 16:14:03 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s65KE2Sd004296 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 5 Jul 2014 16:14:02 -0400 Message-ID: <53B85C89.4070306@redhat.com> Date: Sat, 05 Jul 2014 22:14:01 +0200 From: Max Reitz MIME-Version: 1.0 References: <1404489305-8750-1-git-send-email-kwolf@redhat.com> <1404489305-8750-5-git-send-email-kwolf@redhat.com> In-Reply-To: <1404489305-8750-5-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] block: Assert qiov length matches request length List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: stefanha@redhat.com On 04.07.2014 17:55, Kevin Wolf wrote: > At least raw-posix relies on this because it can allocate bounce buffers > based on the request length, but access it using all of the qiov entries > later. > > Signed-off-by: Kevin Wolf > --- > block.c | 2 ++ > block/raw-posix.c | 15 +++++++++++---- > 2 files changed, 13 insertions(+), 4 deletions(-) Somehow I'm not sure whether I want to give my R-b to this, in case one of these assertions should fail. ;-) But they look correct (considering QIO vectors now have to be just as long as the request), so: Reviewed-by: Max Reitz