From: Paolo Bonzini <pbonzini@redhat.com>
To: Cole Robinson <crobinso@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Andreas Faerber <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] qmp: show QOM properties in device-list-properties
Date: Mon, 07 Jul 2014 08:54:59 +0200 [thread overview]
Message-ID: <53BA4443.8000801@redhat.com> (raw)
In-Reply-To: <53B99D99.5050304@redhat.com>
Il 06/07/2014 21:03, Cole Robinson ha scritto:
> On 07/05/2014 05:14 AM, Paolo Bonzini wrote:
>> Il 20/05/2014 14:29, Stefan Hajnoczi ha scritto:
>>> Devices can use a mix of qdev and QOM properties. Currently only the
>>> qdev properties are displayed by device-list-properties.
>>>
>>> This patch extends the property enumeration algorithm to also display
>>> QOM properties (excluding the implicit "type", "realized",
>>> "hotpluggable", and "parent_bus" properties).
>>>
>>> When a qdev property exists, use the qdev type name to preserve
>>> backwards compatibility. QOM type names can be different for bool (qdev
>>> on/off) and str (used by qdev pointers).
>>>
>>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>
>>
>> Stefan, was this never applied?
>>
>
> I assume you CC'd me in reference to the bug I reported:
>
> https://lists.gnu.org/archive/html/qemu-devel/2014-07/msg00882.html
>
> I tested this patch, but it doesn't fix the specific bit I mentioned (lack of
> 'bootindex' in -device virtio-blk,? )
Yes, it doesn't, but does libvirt work then? I'm not sure if libvirt
still uses -device or rather device-list-properties (which lets you
start a single QEMU process and do multiple probes).
Paolo
next prev parent reply other threads:[~2014-07-07 6:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 12:29 [Qemu-devel] [PATCH] qmp: show QOM properties in device-list-properties Stefan Hajnoczi
2014-07-05 9:14 ` Paolo Bonzini
2014-07-06 19:03 ` Cole Robinson
2014-07-07 6:54 ` Paolo Bonzini [this message]
2014-07-07 7:29 ` Markus Armbruster
2014-07-07 12:40 ` Christian Borntraeger
2014-07-07 9:02 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BA4443.8000801@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=crobinso@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).