From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X42pU-0004OJ-6x for qemu-devel@nongnu.org; Mon, 07 Jul 2014 02:55:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X42pO-0006uM-FT for qemu-devel@nongnu.org; Mon, 07 Jul 2014 02:55:12 -0400 Received: from mail-qa0-x235.google.com ([2607:f8b0:400d:c00::235]:54112) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X42pO-0006sf-Ai for qemu-devel@nongnu.org; Mon, 07 Jul 2014 02:55:06 -0400 Received: by mail-qa0-f53.google.com with SMTP id j15so3187435qaq.12 for ; Sun, 06 Jul 2014 23:55:05 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53BA4443.8000801@redhat.com> Date: Mon, 07 Jul 2014 08:54:59 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1400588941-12347-1-git-send-email-stefanha@redhat.com> <53B7C1E3.1010103@redhat.com> <53B99D99.5050304@redhat.com> In-Reply-To: <53B99D99.5050304@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qmp: show QOM properties in device-list-properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson , Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Peter Maydell , Andreas Faerber Il 06/07/2014 21:03, Cole Robinson ha scritto: > On 07/05/2014 05:14 AM, Paolo Bonzini wrote: >> Il 20/05/2014 14:29, Stefan Hajnoczi ha scritto: >>> Devices can use a mix of qdev and QOM properties. Currently only the >>> qdev properties are displayed by device-list-properties. >>> >>> This patch extends the property enumeration algorithm to also display >>> QOM properties (excluding the implicit "type", "realized", >>> "hotpluggable", and "parent_bus" properties). >>> >>> When a qdev property exists, use the qdev type name to preserve >>> backwards compatibility. QOM type names can be different for bool (qdev >>> on/off) and str (used by qdev pointers). >>> >>> Signed-off-by: Stefan Hajnoczi > >> >> Stefan, was this never applied? >> > > I assume you CC'd me in reference to the bug I reported: > > https://lists.gnu.org/archive/html/qemu-devel/2014-07/msg00882.html > > I tested this patch, but it doesn't fix the specific bit I mentioned (lack of > 'bootindex' in -device virtio-blk,? ) Yes, it doesn't, but does libvirt work then? I'm not sure if libvirt still uses -device or rather device-list-properties (which lets you start a single QEMU process and do multiple probes). Paolo