From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X48Dv-0005jp-3f for qemu-devel@nongnu.org; Mon, 07 Jul 2014 08:40:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X48Dm-0001Jl-AM for qemu-devel@nongnu.org; Mon, 07 Jul 2014 08:40:46 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:56728) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X48Dl-0001JJ-Su for qemu-devel@nongnu.org; Mon, 07 Jul 2014 08:40:38 -0400 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 Jul 2014 13:40:36 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 9906F1B08069 for ; Mon, 7 Jul 2014 13:41:11 +0100 (BST) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s67CeY4B28573886 for ; Mon, 7 Jul 2014 12:40:34 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s67CeWpl029482 for ; Mon, 7 Jul 2014 06:40:33 -0600 Message-ID: <53BA953F.8080005@de.ibm.com> Date: Mon, 07 Jul 2014 14:40:31 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1400588941-12347-1-git-send-email-stefanha@redhat.com> <53B7C1E3.1010103@redhat.com> <53B99D99.5050304@redhat.com> <53BA4443.8000801@redhat.com> <87simd4ofa.fsf@blackfin.pond.sub.org> In-Reply-To: <87simd4ofa.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qmp: show QOM properties in device-list-properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Paolo Bonzini Cc: Peter Maydell , Cole Robinson , Andreas Faerber , Stefan Hajnoczi , qemu-devel@nongnu.org On 07/07/14 09:29, Markus Armbruster wrote: > Paolo Bonzini writes: > >> Il 06/07/2014 21:03, Cole Robinson ha scritto: >>> On 07/05/2014 05:14 AM, Paolo Bonzini wrote: >>>> Il 20/05/2014 14:29, Stefan Hajnoczi ha scritto: >>>>> Devices can use a mix of qdev and QOM properties. Currently only the >>>>> qdev properties are displayed by device-list-properties. >>>>> >>>>> This patch extends the property enumeration algorithm to also display >>>>> QOM properties (excluding the implicit "type", "realized", >>>>> "hotpluggable", and "parent_bus" properties). >>>>> >>>>> When a qdev property exists, use the qdev type name to preserve >>>>> backwards compatibility. QOM type names can be different for bool (qdev >>>>> on/off) and str (used by qdev pointers). >>>>> >>>>> Signed-off-by: Stefan Hajnoczi >>> >>>> >>>> Stefan, was this never applied? >>>> >>> >>> I assume you CC'd me in reference to the bug I reported: >>> >>> https://lists.gnu.org/archive/html/qemu-devel/2014-07/msg00882.html >>> >>> I tested this patch, but it doesn't fix the specific bit I mentioned (lack of >>> 'bootindex' in -device virtio-blk,? ) >> >> Yes, it doesn't, but does libvirt work then? I'm not sure if libvirt >> still uses -device or rather device-list-properties (which lets you >> start a single QEMU process and do multiple probes). Libvirt still seems to used -device FOO,help With current qemu master (plus this fix), I get "unsupported configuration: hypervisor lacks deviceboot feature" > > Valid question, but of course we need to fix the -device FOO,help > regression regardless. >