From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42528)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <a.rigo@virtualopensystems.com>) id 1X48v3-0007af-Mf
	for qemu-devel@nongnu.org; Mon, 07 Jul 2014 09:25:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <a.rigo@virtualopensystems.com>) id 1X48uw-0001OO-V2
	for qemu-devel@nongnu.org; Mon, 07 Jul 2014 09:25:21 -0400
Received: from mail-wi0-f179.google.com ([209.85.212.179]:41395)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <a.rigo@virtualopensystems.com>) id 1X48uw-0001OC-Oe
	for qemu-devel@nongnu.org; Mon, 07 Jul 2014 09:25:14 -0400
Received: by mail-wi0-f179.google.com with SMTP id cc10so6719046wib.0
	for <qemu-devel@nongnu.org>; Mon, 07 Jul 2014 06:25:08 -0700 (PDT)
Message-ID: <53BA9FB0.3070801@virtualopensystems.com>
Date: Mon, 07 Jul 2014 15:25:04 +0200
From: Alvise Rigo <a.rigo@virtualopensystems.com>
MIME-Version: 1.0
References: <1404736043-22900-1-git-send-email-eric.auger@linaro.org>
	<1404736043-22900-9-git-send-email-eric.auger@linaro.org>
	<20140707124955.GH3676@arm.com>
In-Reply-To: <20140707124955.GH3676@arm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v4 08/13] hw/vfio/common: Add EXEC_FLAG to
	VFIO DMA mappings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Will Deacon <will.deacon@arm.com>, Eric Auger <eric.auger@linaro.org>
Cc: "peter.maydell@linaro.org" <peter.maydell@linaro.org>, "kim.phillips@freescale.com" <kim.phillips@freescale.com>, "eric.auger@st.com" <eric.auger@st.com>, "patches@linaro.org" <patches@linaro.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "agraf@suse.de" <agraf@suse.de>, "Bharat.Bhushan@freescale.com" <Bharat.Bhushan@freescale.com>, "alex.williamson@redhat.com" <alex.williamson@redhat.com>, "stuart.yoder@freescale.com" <stuart.yoder@freescale.com>, "a.motakis@virtualopensystems.com" <a.motakis@virtualopensystems.com>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>, "christoffer.dall@linaro.org" <christoffer.dall@linaro.org>

Il 07/07/2014 14:49, Will Deacon ha scritto:
> On Mon, Jul 07, 2014 at 01:27:18PM +0100, Eric Auger wrote:
>> From: Alvise Rigo <a.rigo@virtualopensystems.com>
>>
>> The flag is mandatory for the ARM SMMU so we always add it if the MMIO
>> handles it.
> 
> I though the logic of this flag was changing (so that you request an NX
> mapping instead), so I'd hold off on this change until the kernel has
> decided what it's doing.

Yes, you are right.
This patch is not needed anymore, in fact it was dropped in my last
patch series.
It should not be here, please ignore it.

Regards,
alvise

> 
> Also, the ARM SMMU doesn't mandate any flags, you probably need this as
> a result of using a PL330, which is an odd case of a DMA master that
> spits out EXEC transactions (instruction fetch).
> 
> Will
>