From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4ATi-00006J-4S for qemu-devel@nongnu.org; Mon, 07 Jul 2014 11:05:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4ATb-00050E-MC for qemu-devel@nongnu.org; Mon, 07 Jul 2014 11:05:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3047) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4ATb-0004zS-D7 for qemu-devel@nongnu.org; Mon, 07 Jul 2014 11:05:07 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s67F56UX027940 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 7 Jul 2014 11:05:06 -0400 Message-ID: <53BAB721.8010605@redhat.com> Date: Mon, 07 Jul 2014 09:05:05 -0600 From: Eric Blake MIME-Version: 1.0 References: <1404489305-8750-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1404489305-8750-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FIIjkIaR4U1KV7H6lEkiwEhTNXS2O0l5A" Subject: Re: [Qemu-devel] [PATCH for-2.1 0/4] block: Fix qiov sizes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FIIjkIaR4U1KV7H6lEkiwEhTNXS2O0l5A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/04/2014 09:55 AM, Kevin Wolf wrote: > Some callers use larger qiovs than nb_sectors for their read requests. = This is > bad because raw-posix uses nb_sectors to allocate a bounce buffer and t= hen > copies the whole iov over. >=20 > This series fixes some more cases (mirroring was already fixed earlier = this > week) and adds assertions to catch any other offenders. Is the intent to include this in 2.1? >=20 > Kevin Wolf (4): > block: Make qiov match the request size until EOF > qcow2: Make qiov match request size until backing file EOF > qed: Make qiov match request size until backing file EOF > block: Assert qiov length matches request length >=20 > block.c | 13 ++++++++++++- > block/qcow2.c | 11 ++++++++++- > block/qed.c | 26 +++++++++++++++++++++++--- > block/qed.h | 1 + > block/raw-posix.c | 15 +++++++++++---- > 5 files changed, 57 insertions(+), 9 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --FIIjkIaR4U1KV7H6lEkiwEhTNXS2O0l5A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTurchAAoJEKeha0olJ0Nq2E0IAKKgS0JFrIlNBmgyfeBEQCZ/ pJeEhLURqdEn2/4phDEyuruny8pvjycSFtVkCoPjQRuxEMXfu5UzleIJ49nXglla wB6z4siVQ8X3Ic/Hh/Uc5i2SgXDL8LOUdoNQFkcSU7KMqVQlXLxgN1S/6V6yZYqF yjQDh/5DRSc7sJrbBB9uiw+GnEbTocWBHZHLkwFSiNxX+oPIhJO+TcHi9xLgXFhS UdTtqjsYtrTEpbT6O60eId/Ate8qsio5obyfPHrgO6NqP0vsPM51I/KY/JJ7pTm5 wae/mYAdFw9X0NX4zLODn60Zi1WP8fnqC9XmJjeQd3v6ERB3C71vrjWkCAKF7wQ= =YMRq -----END PGP SIGNATURE----- --FIIjkIaR4U1KV7H6lEkiwEhTNXS2O0l5A--