From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4B8B-0007Mw-GD for qemu-devel@nongnu.org; Mon, 07 Jul 2014 11:47:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4B85-0001lI-O1 for qemu-devel@nongnu.org; Mon, 07 Jul 2014 11:47:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32613) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4B85-0001lD-E2 for qemu-devel@nongnu.org; Mon, 07 Jul 2014 11:46:57 -0400 Message-ID: <53BAC0E8.9090608@redhat.com> Date: Mon, 07 Jul 2014 09:46:48 -0600 From: Eric Blake MIME-Version: 1.0 References: <1404495717-4239-1-git-send-email-dgilbert@redhat.com> <1404495717-4239-2-git-send-email-dgilbert@redhat.com> In-Reply-To: <1404495717-4239-2-git-send-email-dgilbert@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aDdFkk5L1kfn6jPctHwvR2Ml7FKjVIG76" Subject: Re: [Qemu-devel] [PATCH 01/46] qemu_ram_foreach_block: pass up error value, and down the ramblock name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aDdFkk5L1kfn6jPctHwvR2Ml7FKjVIG76 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/04/2014 11:41 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" >=20 > check the return value of the function it calls and error if it's none-= 0 > Fixup qemu_rdma_init_one_block that is the only current caller, > and __qemu_rdma_add_block the only function it calls using it. As long as you are at it, is it worth renaming the use of __qemu prefix in a function name? That namespace is reserved for the compiler/libc, and we shouldn't be stomping on it. Probably best as a separate patch. >=20 > Pass the name of the ramblock to the function; helps in debugging. >=20 > Signed-off-by: Dr. David Alan Gilbert > --- > exec.c | 10 ++++++++-- > include/exec/cpu-common.h | 4 ++-- > migration-rdma.c | 4 ++-- > 3 files changed, 12 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --aDdFkk5L1kfn6jPctHwvR2Ml7FKjVIG76 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTusDoAAoJEKeha0olJ0NqS+cH/0eo5lDV5eY5+hdPMP+XNDQw RAh1Ctp8RNLabLDZQx9CdUfLqCabw1QKVFvsGAdhpgu2OBh63dZdGdCauFQSEZMI z6PTLHt4lXXeArBcvpgKv9PrGShs6Lu/CJcM1inQDirxDwWMMeAwBG1SN4RO3Gkq b8CsKDGcjaa/BWrZlqSQimWr+x2bq8jBFzZQ3h7KIywelpSFXzWnthfWTEfuT5cr +nZRIX1GpMth50fu1kXmlW1ClY3Cryqe5bB+3ZHwN8oC7r9NO/0MfitWdA2lNZ0r jszdrkuZSZCaXkWFahHnJi/vqRD3t9URFhs3HFIT16XBcatp0qCXlSrfXrwdV+s= =sJxa -----END PGP SIGNATURE----- --aDdFkk5L1kfn6jPctHwvR2Ml7FKjVIG76--