From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4E39-00010q-Se for qemu-devel@nongnu.org; Mon, 07 Jul 2014 14:54:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4E34-0007qS-46 for qemu-devel@nongnu.org; Mon, 07 Jul 2014 14:54:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4E33-0007pg-QQ for qemu-devel@nongnu.org; Mon, 07 Jul 2014 14:53:58 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s67Irvva005350 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 7 Jul 2014 14:53:57 -0400 Message-ID: <53BAECC4.6040701@redhat.com> Date: Mon, 07 Jul 2014 12:53:56 -0600 From: Eric Blake MIME-Version: 1.0 References: <1404582448-23840-1-git-send-email-mreitz@redhat.com> <1404582448-23840-6-git-send-email-mreitz@redhat.com> In-Reply-To: <1404582448-23840-6-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rmQin71i8SsnLXfnIUiOcLFB5cMxDNMnP" Subject: Re: [Qemu-devel] [PATCH v9 05/14] blockjob: Add "ready" field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rmQin71i8SsnLXfnIUiOcLFB5cMxDNMnP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/05/2014 11:47 AM, Max Reitz wrote: > When a block job signals readiness, this is currently reported only > through QMP. If qemu wants to use block jobs for internal tasks, there > needs to be another way to correctly detect when a block job may be > completed. >=20 > For this reason, introduce a bool "ready" which is set when the block > job may be completed. >=20 > Signed-off-by: Max Reitz > --- > blockjob.c | 3 +++ > include/block/blockjob.h | 5 +++++ > qapi/block-core.json | 4 +++- > 3 files changed, 11 insertions(+), 1 deletion(-) >=20 > +++ b/qapi/block-core.json > @@ -505,12 +505,14 @@ > # > # @io-status: the status of the job (since 1.3) > # > +# @ready: true if the job may be completed (since 2.1) Isn't this 2.2 now, or are you still shooting for calling this a bug fix in 2.1 hard freeze? Depending on the answer, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --rmQin71i8SsnLXfnIUiOcLFB5cMxDNMnP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTuuzEAAoJEKeha0olJ0NqQCUIAKX9Bc2UlmIn7YLik1PveX4M CQinymiopekBXQKSHaNt+EzoQQuzHkCM1UQVTHdnsXRNEeaLtR+q1duWLItKyzUM 9JUk58fYDFMckolC1c+4w51szzs/5J+YCTOjuFrOjB+MBnQu2Lh8OJWKXaFbg6KU 4Gb0Vq3OtsRdXTuyPx0ru0sM6+ptRoQSjjJ9PD/FJ47oFWzBMBhr8aEVfS6X9rXT /0MA3EnCGXOHx0+hHTQh+D8uZemNLAj29c3jblAll4Nn7GQlcNpw+0ha8nRrgZUW KgXIQm2VWG4/8LukD6bsyqDFKhIkXkDYm+OQuLvw4/drABXKX/cw5MMIb5G1Kvw= =gRVu -----END PGP SIGNATURE----- --rmQin71i8SsnLXfnIUiOcLFB5cMxDNMnP--