From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4EMr-0002tD-JP for qemu-devel@nongnu.org; Mon, 07 Jul 2014 15:14:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4EMe-0006bs-Ah for qemu-devel@nongnu.org; Mon, 07 Jul 2014 15:14:25 -0400 Received: from mail-qg0-x232.google.com ([2607:f8b0:400d:c04::232]:63907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4EMe-0006bm-5j for qemu-devel@nongnu.org; Mon, 07 Jul 2014 15:14:12 -0400 Received: by mail-qg0-f50.google.com with SMTP id j5so4007725qga.37 for ; Mon, 07 Jul 2014 12:14:11 -0700 (PDT) Sender: Richard Henderson Message-ID: <53BAF17F.7030703@twiddle.net> Date: Mon, 07 Jul 2014 12:14:07 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1404756822-3253-1-git-send-email-kbastian@mail.uni-paderborn.de> <1404756822-3253-2-git-send-email-kbastian@mail.uni-paderborn.de> In-Reply-To: <1404756822-3253-2-git-send-email-kbastian@mail.uni-paderborn.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-cpu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bastian Koppelmann , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org On 07/07/2014 11:13 AM, Bastian Koppelmann wrote: > + > + /* GPR Register */ > + target_ulong gpr_a[16]; > + target_ulong gpr_d[16]; > +}; > + > +typedef struct tricore_def_t tricore_def_t; > + > +typedef struct CPUTRICOREState CPUTRICOREState; > +struct CPUTRICOREState { > + TCState active_tc; You'll get better code generation if you put the gprs first. Some hosts will need a 2 insn sequence for large offsets, and even x86 will have a code size benefit from having offsets < 128. Is there any real need for the active_tc thing, or did you just copy MIPS? Personally, I dislike it, and unless you're planning on using structure assignment to copy data around during certain context switches, please drop it. r~