From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4EvW-0002oy-Qq for qemu-devel@nongnu.org; Mon, 07 Jul 2014 15:50:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4EvO-0001zL-IT for qemu-devel@nongnu.org; Mon, 07 Jul 2014 15:50:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44277) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4EvO-0001y9-BB for qemu-devel@nongnu.org; Mon, 07 Jul 2014 15:50:06 -0400 Message-ID: <53BAF9E8.7050309@redhat.com> Date: Mon, 07 Jul 2014 13:50:00 -0600 From: Eric Blake MIME-Version: 1.0 References: <1404495717-4239-1-git-send-email-dgilbert@redhat.com> <1404495717-4239-23-git-send-email-dgilbert@redhat.com> In-Reply-To: <1404495717-4239-23-git-send-email-dgilbert@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cbR2WgCXc97vj6AK5IFGm5xb9MJMaICbm" Subject: Re: [Qemu-devel] [PATCH 22/46] Migration parameters: Add qmp/hmp commands for setting/viewing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cbR2WgCXc97vj6AK5IFGm5xb9MJMaICbm Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/04/2014 11:41 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" >=20 > Add somewhere for the various migration parameters to be set with > one command; >=20 > As suggested in the thread: > http://lists.gnu.org/archive/html/qemu-devel/2012-11/msg00243.html That's a bit old; I had a newer suggestion here: https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg02274.html with positive feedback here and in further followups: https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg00653.html >=20 > There are many existing migration parameters that are scattered over > many individual commands; moving those to this scheme would probably br= eak > things for others, so I've left them be. I don't mind having information duplicated into two places. I'd much rather have all the old commands continue to work one item at a time, but have the new command (or new extension to existing command) globally show all tunables, than trying to force management to mix both old and new calls. That is, if the new approach works, libvirt would rather use JUST the new approach instead of a mix of old and new, when managing all the tunables. >=20 > Preserve the migration tunable values across the reinit of the migratio= n > status in the same way that the capability flags are preserved. >=20 > Add completion routine for it. >=20 > Use the postcopy time out setting as the first parameter. >=20 > Signed-off-by: Dr. David Alan Gilbert > --- > hmp-commands.hx | 17 ++++++++++ > hmp.c | 54 ++++++++++++++++++++++++++++++ > hmp.h | 4 +++ > include/migration/migration.h | 4 +++ > migration.c | 78 ++++++++++++++++++++++++++++++++++-= -------- > monitor.c | 25 ++++++++++++++ > qapi-schema.json | 50 +++++++++++++++++++++++++++ > qmp-commands.hx | 23 +++++++++++++ > 8 files changed, 239 insertions(+), 16 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -538,6 +538,56 @@ > { 'command': 'query-migrate-capabilities', 'returns': ['MigrationCap= abilityStatus']} > =20 > ## > +# @MigrationParameterName > +# > +# Migration parameter enumeration > +# Most existing parameters have separate commands/entries but it s= eems > +# better to group them in the same way as the capability flags > +# > +# @x-postcopy-start-time: Time (in ms) after the start of migration to= consider > +# switching to postcopy mode > +# > +# Since: 2.0 Not even close to 2.0 material. This is 2.2 at the earliest. (Several more instances in this patch) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cbR2WgCXc97vj6AK5IFGm5xb9MJMaICbm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEbBAEBCAAGBQJTuvnoAAoJEKeha0olJ0NqFG4H+P2kJXehFZIAeqna53cdrElJ /PRiVK3OGmrAOCZsRisV/TvjeI+sQcMbS8nS4+XAv025mML7Elzw6V8IN9NCAmFW TpptcNxgu/uVi/2btGgdAr4hwIeK69DKt6t3RUu2xKjbeAkY3F1He9JTs2kJVxoJ AAxABnSXlvL8ZvoTnEJ5bjmuYDAi+llTkHWvZAVZYutjfDRlOAi63AcTZEc2CcBz Ydcr17CN5t2C/LhVMN3C10ThXOUW8RU4rIZxosGA80/YAS1kRQwxadk4cWmnICh4 d/ga2k4vkoPnS/b1y4t+LJVWnDlVPJOCz+csAaP3p5Ik+TcQffrkuYHAgBdwcA== =e5Dk -----END PGP SIGNATURE----- --cbR2WgCXc97vj6AK5IFGm5xb9MJMaICbm--