From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59591)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1X4NJe-0001rX-9e
	for qemu-devel@nongnu.org; Tue, 08 Jul 2014 00:47:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1X4NJU-0006f8-Ha
	for qemu-devel@nongnu.org; Tue, 08 Jul 2014 00:47:42 -0400
Received: from mail-qc0-x230.google.com ([2607:f8b0:400d:c01::230]:41339)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1X4NJU-0006dq-CN
	for qemu-devel@nongnu.org; Tue, 08 Jul 2014 00:47:32 -0400
Received: by mail-qc0-f176.google.com with SMTP id w7so4620403qcr.21
	for <qemu-devel@nongnu.org>; Mon, 07 Jul 2014 21:47:32 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <53BB77E0.6020303@twiddle.net>
Date: Mon, 07 Jul 2014 21:47:28 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1404756822-3253-1-git-send-email-kbastian@mail.uni-paderborn.de>
	<1404756822-3253-12-git-send-email-kbastian@mail.uni-paderborn.de>
In-Reply-To: <1404756822-3253-12-git-send-email-kbastian@mail.uni-paderborn.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 11/15] target-tricore: Add instructions of
 SBC and SBRN opcode format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org

On 07/07/2014 11:13 AM, Bastian Koppelmann wrote:
> +/* SBRN-format jumps */
> +    case OPC1_16_SBRN_JZ_T:
> +        temp = tcg_temp_new();
> +        tcg_gen_andi_tl(temp, cpu_gpr_d[15], 0x1u << constant);
> +        gen_branch_condi(ctx, TCG_COND_NE, temp, 0x1 << constant, offset);
> +        tcg_temp_free(temp);
> +        break;
> +    case OPC1_16_SBRN_JNZ_T:
> +        temp = tcg_temp_new();
> +        tcg_gen_andi_tl(temp, cpu_gpr_d[15], 0x1u << constant);
> +        gen_branch_condi(ctx, TCG_COND_EQ, temp, 0x1 << constant, offset);
> +        tcg_temp_free(temp);
> +        break;

Compare vs zero after the andi.


r~