From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>, Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] oslib-posix: Fix new compiler error with -Wclobbered
Date: Tue, 08 Jul 2014 07:38:54 +0200 [thread overview]
Message-ID: <53BB83EE.3020307@redhat.com> (raw)
In-Reply-To: <53BAF51D.1040803@weilnetz.de>
Il 07/07/2014 21:29, Stefan Weil ha scritto:
> Am 24.06.2014 23:03, schrieb Paolo Bonzini:
>> Il 24/06/2014 22:52, Stefan Weil ha scritto:
>>> Newer versions of gcc report a warning (or an error with -Werror) when
>>> compiler option -Wclobbered (or -Wextra) is active:
>>>
>>> util/oslib-posix.c:372:12: error:
>>> variable ‘hpagesize’ might be clobbered by ‘longjmp’ or ‘vfork’
>>> [-Werror=clobbered]
>>>
>>> The rewritten code fixes this warning: variable 'hpagesize' is now set
>>> and
>>> used in a block without any call of sigsetjmp or similar functions.
>>>
>>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>>
>> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>
>
> Ping? Maybe this patch can be committed directly as a build fix for
> people like me who use compiler flag -Wextra.
Ok, I'll pick it up.
Paolo
prev parent reply other threads:[~2014-07-08 5:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 20:52 [Qemu-devel] [PATCH] oslib-posix: Fix new compiler error with -Wclobbered Stefan Weil
2014-06-24 21:03 ` Paolo Bonzini
2014-07-07 19:29 ` Stefan Weil
2014-07-08 5:38 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BB83EE.3020307@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).