From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36576)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X4O7Y-0000w8-Qv
	for qemu-devel@nongnu.org; Tue, 08 Jul 2014 01:39:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X4O7T-0003zq-5c
	for qemu-devel@nongnu.org; Tue, 08 Jul 2014 01:39:16 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53BB83EE.3020307@redhat.com>
Date: Tue, 08 Jul 2014 07:38:54 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1403643149-30440-1-git-send-email-sw@weilnetz.de>	<53A9E789.8040809@redhat.com>
	<53BAF51D.1040803@weilnetz.de>
In-Reply-To: <53BAF51D.1040803@weilnetz.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] oslib-posix: Fix new compiler error with
	-Wclobbered
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>, Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

Il 07/07/2014 21:29, Stefan Weil ha scritto:
> Am 24.06.2014 23:03, schrieb Paolo Bonzini:
>> Il 24/06/2014 22:52, Stefan Weil ha scritto:
>>> Newer versions of gcc report a warning (or an error with -Werror) when
>>> compiler option -Wclobbered (or -Wextra) is active:
>>>
>>> util/oslib-posix.c:372:12: error:
>>>  variable ‘hpagesize’ might be clobbered by ‘longjmp’ or ‘vfork’
>>> [-Werror=clobbered]
>>>
>>> The rewritten code fixes this warning: variable 'hpagesize' is now set
>>> and
>>> used in a block without any call of sigsetjmp or similar functions.
>>>
>>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>>
>> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>
>
> Ping? Maybe this patch can be committed directly as a build fix for
> people like me who use compiler flag -Wextra.

Ok, I'll pick it up.

Paolo