From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4gN2-0001uj-N0 for qemu-devel@nongnu.org; Tue, 08 Jul 2014 21:08:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4gMy-0005nf-A0 for qemu-devel@nongnu.org; Tue, 08 Jul 2014 21:08:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4gMy-0005na-0I for qemu-devel@nongnu.org; Tue, 08 Jul 2014 21:08:24 -0400 Message-ID: <53BC9606.50903@redhat.com> Date: Tue, 08 Jul 2014 19:08:22 -0600 From: Eric Blake MIME-Version: 1.0 References: <1404788914-9992-1-git-send-email-cyliu@suse.com> In-Reply-To: <1404788914-9992-1-git-send-email-cyliu@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="a7L41DNRhiHiQBOltJpENhaTQf5hj2UmF" Subject: Re: [Qemu-devel] [PATCH for 2.1 V2] qemu-img info: show nocow info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu , qemu-devel@nongnu.org Cc: stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --a7L41DNRhiHiQBOltJpENhaTQf5hj2UmF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/07/2014 09:08 PM, Chunyan Liu wrote: > Add nocow info in 'qemu-img info' output to show whether the file > currently has NOCOW flag set or not. >=20 > Signed-off-by: Chunyan Liu > --- > Changes: > - add documentation of "nocow" in qapi/block-core.json. >=20 > @@ -625,4 +646,8 @@ void bdrv_image_info_dump(fprintf_function func_fpr= intf, void *f, > func_fprintf(f, "Format specific information:\n"); > bdrv_image_info_specific_dump(func_fprintf, f, info->format_sp= ecific); > } > + > + if (info->has_nocow && info->nocow) { > + func_fprintf(f, "Set NOCOW flag: yes\n"); Reads awkwardly. How about: NOCOW flag: set (and if we could reliably tell that the fs supports nocow but the flag is clear, then we could have 'NOCOW flag: clear') --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --a7L41DNRhiHiQBOltJpENhaTQf5hj2UmF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTvJYGAAoJEKeha0olJ0NqUKwH/0Efjhh5JKZmUi+gg3QJhWkg OmcSaC7VeIQerneu6qHqaS6W+aMYPZ03kKlW1j/miul7BTKuGkiVECGFNm+rnjEY v/dGtjbl9R69T4vVvpyXWpcetyOqZ69Cp+2+UDZHm5qcr0gc2uZv0n2tea/NPE5r OG8BqkqiDNrSXNb+zW2ybm5514GKJx4wvXKvOvtNVHehwxHT3e2ByzW9kMU+EwpI zrE0NIGHEoviZ+Yum4zJX/W6kaR3bE4iHNA7Bj/99bjmxRl9C0QLC/U9u79A6kpi tIDIQnbNOtnB3r1upq29/tzF9wlF3yRNp7im4C/AY7QRHJTp9Pbbyl5EioQggmI= =z8eG -----END PGP SIGNATURE----- --a7L41DNRhiHiQBOltJpENhaTQf5hj2UmF--