From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: stefanha@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 for-2.1 3/4] qed: Make qiov match request size until backing file EOF
Date: Tue, 08 Jul 2014 19:52:12 -0600 [thread overview]
Message-ID: <53BCA04C.70204@redhat.com> (raw)
In-Reply-To: <1404825299-2827-1-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 801 bytes --]
On 07/08/2014 07:14 AM, Kevin Wolf wrote:
> If a QED image has a shorter backing file and a read request to
> unallocated clusters goes across EOF of the backing file, the backing
> file sees a shortened request and the rest is filled with zeros.
> However, the original too long qiov was used with the shortened request.
>
> This patch makes the qiov size match the request size, avoiding a
> potential buffer overflow in raw-posix.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/qed.c | 38 ++++++++++++++++++++++++++++++--------
> block/qed.h | 1 +
> 2 files changed, 31 insertions(+), 8 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-07-09 1:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 15:55 [Qemu-devel] [PATCH 0/4] block: Fix qiov sizes Kevin Wolf
2014-07-04 15:55 ` [Qemu-devel] [PATCH 1/4] block: Make qiov match the request size until EOF Kevin Wolf
2014-07-05 19:19 ` Max Reitz
2014-07-04 15:55 ` [Qemu-devel] [PATCH 2/4] qcow2: Make qiov match request size until backing file EOF Kevin Wolf
2014-07-05 19:37 ` Max Reitz
2014-07-04 15:55 ` [Qemu-devel] [PATCH 3/4] qed: " Kevin Wolf
2014-07-05 20:06 ` Max Reitz
2014-07-08 13:07 ` Kevin Wolf
2014-07-08 13:14 ` [Qemu-devel] [PATCH v2 for-2.1 " Kevin Wolf
2014-07-09 1:52 ` Eric Blake [this message]
2014-07-04 15:55 ` [Qemu-devel] [PATCH 4/4] block: Assert qiov length matches request length Kevin Wolf
2014-07-05 20:14 ` Max Reitz
2014-07-07 15:05 ` [Qemu-devel] [PATCH for-2.1 0/4] block: Fix qiov sizes Eric Blake
2014-07-09 11:34 ` [Qemu-devel] [PATCH " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BCA04C.70204@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).