From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47646)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1X4rCh-00027b-7X
	for qemu-devel@nongnu.org; Wed, 09 Jul 2014 08:42:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1X4rCd-0005Zb-0U
	for qemu-devel@nongnu.org; Wed, 09 Jul 2014 08:42:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25713)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1X4rCc-0005Yg-Nl
	for qemu-devel@nongnu.org; Wed, 09 Jul 2014 08:42:26 -0400
Message-ID: <53BD38AA.7060608@redhat.com>
Date: Wed, 09 Jul 2014 06:42:18 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1404834310-12856-1-git-send-email-ming.lei@canonical.com>
	<20140709082951.GA5152@stefanha-thinkpad.redhat.com>
In-Reply-To: <20140709082951.GA5152@stefanha-thinkpad.redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="6495EqBAgfdgjewTtQwaXQ57MnhvmJMPh"
Subject: Re: [Qemu-devel] [PATCH] linux-aio: fix submit aio as a batch
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, Ming Lei <ming.lei@canonical.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Fam Zheng <famz@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--6495EqBAgfdgjewTtQwaXQ57MnhvmJMPh
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 07/09/2014 02:29 AM, Stefan Hajnoczi wrote:

>> +        if (enqueue)
>> +            return ret;
>=20
> Please set up a git hook to run checkpatch.pl.  It will alert you when
> you violate QEMU coding style:
> http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.=
html
>=20
> I already mentioned coding style in previous patches, using a git hook
> will avoid it happening again.

Nice trick; I've added it to http://wiki.qemu.org/Contribute/SubmitAPatch=


--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--6495EqBAgfdgjewTtQwaXQ57MnhvmJMPh
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJTvTiqAAoJEKeha0olJ0NqB/oH/iHtPOdPjzQGY+LyfvP+fqwC
ecRf8vxWhTJwTrWEAS626sLdCpHVEehy66H+PssKUnr5oGg2j0KTJFqzNaIGbp8L
QFJE3M6OCiyvkMSLEWaE13KD8L7f4B9pecmYi41uIC/khKklOTUT6caf7GNpgNzD
0DBnTszklE4Jashfro9rn63Qq/Hwja1TC6GOQhYJ1029AHg/6jg5Ytw+GfWC8Q5f
Gxd/ILIN1EG6yZ28rP/DtffMoPgIK0hKueApXyRIoLLvBVC9C2JpjlMkI7ihSsZN
N5xQPCu2FlRjzHiK2WX2TowIxC/REnwckhq3Qn3qnwMM+1/F10yHZh9oVongyBg=
=xC4I
-----END PGP SIGNATURE-----

--6495EqBAgfdgjewTtQwaXQ57MnhvmJMPh--