qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
	Andreas Faerber <afaerber@suse.de>,
	crobinso@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-2.1 1/2] qmp: hide "hotplugged" device property from device-list-properties
Date: Wed, 09 Jul 2014 06:47:31 -0600	[thread overview]
Message-ID: <53BD39E3.9050007@redhat.com> (raw)
In-Reply-To: <1404907292-20442-2-git-send-email-stefanha@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]

On 07/09/2014 06:01 AM, Stefan Hajnoczi wrote:
> The "hotplugged" device property was not reported before commit
> f4eb32b590bf58c1c67570775eb78beb09964fad ("qmp: show QOM properties in
> device-list-properties").  Fix this difference.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  qmp.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/qmp.c b/qmp.c
> index 0d2553a..c6767c4 100644
> --- a/qmp.c
> +++ b/qmp.c
> @@ -509,6 +509,7 @@ DevicePropertyInfoList *qmp_device_list_properties(const char *typename,
>          if (strcmp(prop->name, "type") == 0 ||
>              strcmp(prop->name, "realized") == 0 ||
>              strcmp(prop->name, "hotpluggable") == 0 ||
> +            strcmp(prop->name, "hotplugged") == 0 ||
>              strcmp(prop->name, "parent_bus") == 0) {
>              continue;
>          }
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2014-07-09 12:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-09 12:01 [Qemu-devel] [PATCH for-2.1 0/2] qdev-monitor: include QOM device properties in -device FOO, help output Stefan Hajnoczi
2014-07-09 12:01 ` [Qemu-devel] [PATCH for-2.1 1/2] qmp: hide "hotplugged" device property from device-list-properties Stefan Hajnoczi
2014-07-09 12:47   ` Eric Blake [this message]
2014-07-09 12:01 ` [Qemu-devel] [PATCH for-2.1 2/2] qdev-monitor: include QOM properties in -device FOO, help output Stefan Hajnoczi
2014-07-09 12:49   ` Eric Blake
2014-07-09 15:20   ` Cole Robinson
2014-07-29 13:32 ` [Qemu-devel] [PATCH for-2.1 0/2] qdev-monitor: include QOM device " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BD39E3.9050007@redhat.com \
    --to=eblake@redhat.com \
    --cc=afaerber@suse.de \
    --cc=armbru@redhat.com \
    --cc=crobinso@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).