From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4rHf-0002zv-Fg for qemu-devel@nongnu.org; Wed, 09 Jul 2014 08:47:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4rHa-0007Qo-I2 for qemu-devel@nongnu.org; Wed, 09 Jul 2014 08:47:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4rHa-0007OY-8E for qemu-devel@nongnu.org; Wed, 09 Jul 2014 08:47:34 -0400 Message-ID: <53BD39E3.9050007@redhat.com> Date: Wed, 09 Jul 2014 06:47:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <1404907292-20442-1-git-send-email-stefanha@redhat.com> <1404907292-20442-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1404907292-20442-2-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xrqwtNgjGKso7SgIf2AEPPpT6O7NLIBAx" Subject: Re: [Qemu-devel] [PATCH for-2.1 1/2] qmp: hide "hotplugged" device property from device-list-properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Markus Armbruster , Andreas Faerber , crobinso@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xrqwtNgjGKso7SgIf2AEPPpT6O7NLIBAx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/09/2014 06:01 AM, Stefan Hajnoczi wrote: > The "hotplugged" device property was not reported before commit > f4eb32b590bf58c1c67570775eb78beb09964fad ("qmp: show QOM properties in > device-list-properties"). Fix this difference. >=20 > Signed-off-by: Stefan Hajnoczi > --- > qmp.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake >=20 > diff --git a/qmp.c b/qmp.c > index 0d2553a..c6767c4 100644 > --- a/qmp.c > +++ b/qmp.c > @@ -509,6 +509,7 @@ DevicePropertyInfoList *qmp_device_list_properties(= const char *typename, > if (strcmp(prop->name, "type") =3D=3D 0 || > strcmp(prop->name, "realized") =3D=3D 0 || > strcmp(prop->name, "hotpluggable") =3D=3D 0 || > + strcmp(prop->name, "hotplugged") =3D=3D 0 || > strcmp(prop->name, "parent_bus") =3D=3D 0) { > continue; > } >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xrqwtNgjGKso7SgIf2AEPPpT6O7NLIBAx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTvTnjAAoJEKeha0olJ0NqU6UIAKB8NsOYWTi1PY1Nk1e55COt UiH6jRyPN36kbo9xEMh+AHue9Zhlo1j//ZsViRHUd/YwpRK4P23a/6y0kAPAh3R9 z6yqB4Iz/vbfoNTDbaZHjApSOCK2KCT+cjyj7y+Q4CeC4tX9qNX+ixKpyAi0ZSlP 7Blrvlos6sIupd4feyBwj3de4Y7zbiwWxaMv9x/4Br1o7tvl3egt4ZV3uUQ4zDjH 7l/MBWK91XiauU7v4iqqk6Sa3NakAIF4YT46Sfa1Opx4+OqTHiv39+sH9IUd5ZXS OzkWIMMZarYx5nC4sXX0Zc/KX+KmMstLJQTRDmYf1Vb9i3rAxUfMHVhiymVJtNk= =qxeC -----END PGP SIGNATURE----- --xrqwtNgjGKso7SgIf2AEPPpT6O7NLIBAx--