From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4rJO-000334-UO for qemu-devel@nongnu.org; Wed, 09 Jul 2014 08:49:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4rJK-0007oW-0g for qemu-devel@nongnu.org; Wed, 09 Jul 2014 08:49:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39322) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4rJJ-0007oS-Mf for qemu-devel@nongnu.org; Wed, 09 Jul 2014 08:49:21 -0400 Message-ID: <53BD3A4F.4000002@redhat.com> Date: Wed, 09 Jul 2014 06:49:19 -0600 From: Eric Blake MIME-Version: 1.0 References: <1404907292-20442-1-git-send-email-stefanha@redhat.com> <1404907292-20442-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1404907292-20442-3-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2qAMeP1RH8KNpFanIQbnGu6a2K1cnQknW" Subject: Re: [Qemu-devel] [PATCH for-2.1 2/2] qdev-monitor: include QOM properties in -device FOO, help output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Markus Armbruster , Andreas Faerber , crobinso@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2qAMeP1RH8KNpFanIQbnGu6a2K1cnQknW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/09/2014 06:01 AM, Stefan Hajnoczi wrote: > Update -device FOO,help to include QOM properties in addition to qdev > properties. Devices are gradually adding more QOM properties that are > not reflected as qdev properties. >=20 > It is important to report all device properties since management tools > like libvirt use this information (and device-list-properties QMP) to > detect the presence of QEMU features. >=20 > This patch reuses the device-list-properties QMP machinery to avoid cod= e > duplication. >=20 > Reported-by: Cole Robinson > Signed-off-by: Stefan Hajnoczi > --- > qdev-monitor.c | 40 +++++++++++++++++----------------------- > 1 file changed, 17 insertions(+), 23 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2qAMeP1RH8KNpFanIQbnGu6a2K1cnQknW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTvTpPAAoJEKeha0olJ0NqIOcH/jnFznviRORlPFENwdLHyt3s mj9G5WCKEochnTzTLTMn/lGMby6jm/vFBlmrvd4nkvzaywnbqmeAWudEdj62LRnE T2BYdYq/HeipFQ1u6DntSEFQLubQseRNBmzHJsG++Au5VhYyUOJdbH0QvgkeXtdW H8IAcxPxy9Pm/U9+ZXnVInkHsBy9kFwJYjPyYXHX/zPfsPBU4FW7Vb8PRhGTyeqc LM5QrS9cxCWms/OY0BdI/zBU7Z6Nz70jvytvgqTLkb9mzp7apH4Z2nVH0ySGCqMn pkHvzbiqZ32W2fplo4g0UwmXaK2jGgBsdcVx2y2sZ23msOqoaBFPDGqTPMLWe1k= =cA6M -----END PGP SIGNATURE----- --2qAMeP1RH8KNpFanIQbnGu6a2K1cnQknW--