From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4sLF-0002TM-9d for qemu-devel@nongnu.org; Wed, 09 Jul 2014 09:55:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4sLA-00046e-3v for qemu-devel@nongnu.org; Wed, 09 Jul 2014 09:55:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4sL9-00046U-R0 for qemu-devel@nongnu.org; Wed, 09 Jul 2014 09:55:20 -0400 Message-ID: <53BD49BC.1030207@redhat.com> Date: Wed, 09 Jul 2014 07:55:08 -0600 From: Eric Blake MIME-Version: 1.0 References: <1403602356-13687-1-git-send-email-pl@kamp.de> <874mz919w5.fsf@troll.troll> <20140709042557.GA10283@grmbl.mre> <20140709104457.GE27615@grmbl.mre> <20140709105620.GG27615@grmbl.mre> <53BD4267.2030303@kamp.de> In-Reply-To: <53BD4267.2030303@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aeLWaDASwvcv7ebUeLDge8g0h6pFuhQFG" Subject: Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , Peter Maydell , Amit Shah Cc: Paolo Bonzini , QEMU Developers , "Dr. David Alan Gilbert" , Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aeLWaDASwvcv7ebUeLDge8g0h6pFuhQFG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/09/2014 07:23 AM, Peter Lieven wrote: > Am 09.07.2014 13:00, schrieb Peter Maydell: >> On 9 July 2014 11:56, Amit Shah wrote: >>> On (Wed) 09 Jul 2014 [11:50:18], Peter Maydell wrote: >>>> OK; we're treating those as bugs so yes, I think this is 2.1 >>>> material. Has somebody other than the original author tested >>>> it? (That's a step that would usually be done by Juan as the >>>> maintainer.) If somebody can provide a Tested-by: I'm happy >>>> to apply it to master. >>> Not really sure if Juan did that as part of his 'thanks, applied' >>> workflow, but I'll run this through the autotest migration tests and >>> report back. >> Thanks; it seems better to double-check given where we are in >> the release cycle. > We have also an: >=20 > Reviewed-by: Eric Blake >=20 >=20 > Maybe he tested as well. No, while I did a review, and can even do a compile test, I have not done a migration test, so I'm not comfortable with a Tested-by yet. Is it something you need me to try today? >=20 > If there are any doubts we should postpone this for 2.2. The preceding > patch is in 2.1 and should catch already a lot of cases. I'm 50-50 on whether this is 2.1 material - it is a bug fix for hardening against malicious incoming migration streams, but without testing that it doesn't break normal migration, it is rather late in the game. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --aeLWaDASwvcv7ebUeLDge8g0h6pFuhQFG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTvUm8AAoJEKeha0olJ0Nqv+UH/3I/tWe/WAP/wjKZ/v0JxdEG JK/GXuor6AQh2SgiO3hQFYNhsiSpEROjWhUJUmj/XHozrbQffNf1JM5R1WHNj07/ cInF5phl8/JupKoETyDT9MmPSWeJqi8+AP+FX2vpYaLCO9ZJN3MBOrpgOCNjITmc avIeagGyCFTNslKxuQJAvaExH8jT5SFsdwngaAAPLJmMfHg0y33184YON7BCEH0D j5Fq7OuvY0F4C9buzefdVUIONtkZEjYvjD9tC33EVJYZ1OhahfdiKEpsU48Nc9Ss uFRlSL855KIHJOX5AaKuQ1jPo6Xg1vD4llPcW3RZTu7Hop2cAldOZWdBk1DW8x8= =jsRR -----END PGP SIGNATURE----- --aeLWaDASwvcv7ebUeLDge8g0h6pFuhQFG--