From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4u2L-0004ff-UJ for qemu-devel@nongnu.org; Wed, 09 Jul 2014 11:44:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4u2G-000240-Vu for qemu-devel@nongnu.org; Wed, 09 Jul 2014 11:44:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4u2G-00023k-MA for qemu-devel@nongnu.org; Wed, 09 Jul 2014 11:43:56 -0400 Message-ID: <53BD6339.2080305@redhat.com> Date: Wed, 09 Jul 2014 09:43:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140708141728.412a3f1c@redhat.com> In-Reply-To: <20140708141728.412a3f1c@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6FfUPsm3rHr3bA1Q8WnqDpfDxcEH855Xo" Subject: Re: [Qemu-devel] [PATCH for-2.1?] scripts: qapi-event.py: support vendor extension List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino , qemu-devel Cc: wenchaoqemu@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6FfUPsm3rHr3bA1Q8WnqDpfDxcEH855Xo Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/08/2014 12:17 PM, Luiz Capitulino wrote: > The event code generator barfs when it sees a dot in an event > argument, this makes it impossible to support vendor extensions > in event arguments as they always contain dots. Fix this by > replacing dots by hyphens in the generated code. >=20 > PS: Event names and QMP command arguments may suffer from the > same issue, but I'm not checking/fixing them today. >=20 > Signed-off-by: Luiz Capitulino > --- > scripts/qapi-event.py | 8 ++++---- > scripts/qapi.py | 4 ++++ > 2 files changed, 8 insertions(+), 4 deletions(-) Reviewed-by: Eric Blake This is borderline on whether it is a bug fix worth applying in 2.1 - it is fixing something that is new to this release (event-as-qapi) and which affects downstream vendors; but at the same time, it is something which cannot be triggered _except_ by downstream vendors, which are perfectly capable of applying this patch even if it misses 2.1. I'll leave it up to you. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6FfUPsm3rHr3bA1Q8WnqDpfDxcEH855Xo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTvWM5AAoJEKeha0olJ0Nq7YQH/39BK+ISHZaDcm7S7eGXbKXJ w1myXk7koqTJ4Yy8/ZkrlvlP00Yci97TqsmodaYqGxzqnGSwF1HMBeMSaxi6EODQ 04xX+XUgpCO4DpSXEhOh2zjdDDk4pXgWfToGVJF09AWMxaUTvxqAZyVBdVHvS1wj vh0YIYjkrVqjeUu/GMRbuhqIP0tehTRtx9ONgcZx6WJBMFI2NPkqQcgwayjNxzPs +0GC2KfsbzUOZU8aO5LWB9mEow1SNvX21Cxzy0cJE6rvt2R3gMLNZL7CQb1+i057 hSq5e878JZO5G3sss2jWqBajBsIxAVDaFWoWrHOLnOfD68cAJ6jDyQWCBC6OkLI= =W+L8 -----END PGP SIGNATURE----- --6FfUPsm3rHr3bA1Q8WnqDpfDxcEH855Xo--