From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4yMb-0007f7-KQ for qemu-devel@nongnu.org; Wed, 09 Jul 2014 16:21:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4yMV-0004YK-EU for qemu-devel@nongnu.org; Wed, 09 Jul 2014 16:21:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4yMV-0004Y9-58 for qemu-devel@nongnu.org; Wed, 09 Jul 2014 16:21:07 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s69KL4Kr012595 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 9 Jul 2014 16:21:05 -0400 Message-ID: <53BDA433.8080906@redhat.com> Date: Wed, 09 Jul 2014 22:21:07 +0200 From: Max Reitz MIME-Version: 1.0 References: <1404582448-23840-1-git-send-email-mreitz@redhat.com> <1404582448-23840-6-git-send-email-mreitz@redhat.com> <53BAECC4.6040701@redhat.com> In-Reply-To: <53BAECC4.6040701@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v9 05/14] blockjob: Add "ready" field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi On 07.07.2014 20:53, Eric Blake wrote: > On 07/05/2014 11:47 AM, Max Reitz wrote: >> When a block job signals readiness, this is currently reported only >> through QMP. If qemu wants to use block jobs for internal tasks, there >> needs to be another way to correctly detect when a block job may be >> completed. >> >> For this reason, introduce a bool "ready" which is set when the block >> job may be completed. >> >> Signed-off-by: Max Reitz >> --- >> blockjob.c | 3 +++ >> include/block/blockjob.h | 5 +++++ >> qapi/block-core.json | 4 +++- >> 3 files changed, 11 insertions(+), 1 deletion(-) >> >> +++ b/qapi/block-core.json >> @@ -505,12 +505,14 @@ >> # >> # @io-status: the status of the job (since 1.3) >> # >> +# @ready: true if the job may be completed (since 2.1) > Isn't this 2.2 now, or are you still shooting for calling this a bug fix > in 2.1 hard freeze? Ah, right, I forgot. This should be 2.2, of course. Max > Depending on the answer, > Reviewed-by: Eric Blake