From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>, Max Reitz <mreitz@redhat.com>,
qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v9 06/14] block/mirror: Improve progress report
Date: Wed, 09 Jul 2014 23:24:19 +0200 [thread overview]
Message-ID: <53BDB303.3030601@redhat.com> (raw)
In-Reply-To: <53BAF165.3090702@redhat.com>
Il 07/07/2014 21:13, Eric Blake ha scritto:
> On 07/05/2014 11:47 AM, Max Reitz wrote:
>> Instead of taking the total length of the block device as the block
>> job's length, use the number of dirty sectors. The progress is now the
>> number of sectors mirrored to the target block device. Note that this
>> may result in the job's length increasing during operation, which is
>> however in fact desirable.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>> block/mirror.c | 34 ++++++++++++++++++++++------------
>> 1 file changed, 22 insertions(+), 12 deletions(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
This is an API change... IIUC the length can become bigger than the
underlying device's size. Eric, how would libvirt expose this to
clients and what are the chances that they get confused?
Paolo
next prev parent reply other threads:[~2014-07-09 21:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 17:47 [Qemu-devel] [PATCH v9 00/14] qemu-img: Implement commit like QMP Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 01/14] qcow2: Allow "full" discard Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 02/14] qcow2: Implement bdrv_make_empty() Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 03/14] qcow2: Optimize bdrv_make_empty() Max Reitz
2014-07-09 21:22 ` Paolo Bonzini
2014-07-09 21:38 ` Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 04/14] blockjob: Introduce block_job_complete_sync() Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 05/14] blockjob: Add "ready" field Max Reitz
2014-07-07 18:53 ` Eric Blake
2014-07-09 20:21 ` Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 06/14] block/mirror: Improve progress report Max Reitz
2014-07-07 19:13 ` Eric Blake
2014-07-09 21:24 ` Paolo Bonzini [this message]
2014-07-09 21:36 ` Eric Blake
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 07/14] qemu-img: Implement commit like QMP Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 08/14] qemu-img: Empty image after commit Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 09/14] qemu-img: Enable progress output for commit Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 10/14] qemu-img: Specify backing file " Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 11/14] iotests: Add _filter_qemu_img_map Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 12/14] iotests: Add test for backing-chain commits Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 13/14] iotests: Add test for qcow2's bdrv_make_empty Max Reitz
2014-07-07 19:15 ` Eric Blake
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 14/14] iotests: Omit length/offset test in 040 and 041 Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BDB303.3030601@redhat.com \
--to=pbonzini@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).