From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49558)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X4zLt-0001K1-1t
	for qemu-devel@nongnu.org; Wed, 09 Jul 2014 17:24:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X4zLj-0007mF-Qt
	for qemu-devel@nongnu.org; Wed, 09 Jul 2014 17:24:32 -0400
Received: from mail-vc0-x235.google.com ([2607:f8b0:400c:c03::235]:55156)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1X4zLj-0007m9-M3
	for qemu-devel@nongnu.org; Wed, 09 Jul 2014 17:24:23 -0400
Received: by mail-vc0-f181.google.com with SMTP id il7so8519757vcb.40
	for <qemu-devel@nongnu.org>; Wed, 09 Jul 2014 14:24:23 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53BDB303.3030601@redhat.com>
Date: Wed, 09 Jul 2014 23:24:19 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1404582448-23840-1-git-send-email-mreitz@redhat.com>	<1404582448-23840-7-git-send-email-mreitz@redhat.com>
	<53BAF165.3090702@redhat.com>
In-Reply-To: <53BAF165.3090702@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v9 06/14] block/mirror: Improve progress
	report
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

Il 07/07/2014 21:13, Eric Blake ha scritto:
> On 07/05/2014 11:47 AM, Max Reitz wrote:
>> Instead of taking the total length of the block device as the block
>> job's length, use the number of dirty sectors. The progress is now the
>> number of sectors mirrored to the target block device. Note that this
>> may result in the job's length increasing during operation, which is
>> however in fact desirable.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>  block/mirror.c | 34 ++++++++++++++++++++++------------
>>  1 file changed, 22 insertions(+), 12 deletions(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>

This is an API change... IIUC the length can become bigger than the 
underlying device's size.  Eric, how would libvirt expose this to 
clients and what are the chances that they get confused?

Paolo