From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
xen-devel@lists.xensource.com,
Ian Campbell <Ian.Campbell@citrix.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] pass $($*.o-cflags) first to gcc/g++
Date: Thu, 10 Jul 2014 00:12:20 +0200 [thread overview]
Message-ID: <53BDBE44.3060504@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1407092247000.29039@kaball.uk.xensource.com>
Il 09/07/2014 23:59, Stefano Stabellini ha scritto:
> On Wed, 9 Jul 2014, Paolo Bonzini wrote:
>> What package is it that has the conflicting utils.h file? Any chance to get
>> it fixed in your distro? Here I get:
>>
>> $ find /usr/include/ -name utils.h
>> /usr/include/libnl3/netlink/utils.h
>> /usr/include/libnl3/netlink/cli/utils.h
>> /usr/include/id3/utils.h
>> /usr/include/octave-3.6.4/octave/utils.h
>>
>> but none of them have the path in -I.
>
> It's Xen: when building QEMU as part of the Xen build process,
> tools/Makefile uses --extra-cflags to add the local Xen directories to
> the QEMU include path. However one of the Xen header files is named
> utils.h, conflicting with utils.h from disas/libvixl.
> It seems to be that --extra-cflags should come after the QEMU include
> paths.
I think the bug is in Xen then. I have an oldish checkout and I see:
$ find . -name utils.h
./tools/console/daemon/utils.h
./tools/xenstore/utils.h
Could you move more headers to tools/include/ and avoid polluting
QEMU_CFLAGS?
That said, for this particular case not using foo.o-cflags can be a
stopgap solution too.
Paolo
next prev parent reply other threads:[~2014-07-09 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 20:34 [Qemu-devel] [PATCH] pass $($*.o-cflags) first to gcc/g++ Stefano Stabellini
2014-07-09 21:11 ` Paolo Bonzini
2014-07-09 21:56 ` Peter Maydell
2014-07-09 21:59 ` Stefano Stabellini
2014-07-09 22:12 ` Paolo Bonzini [this message]
2014-07-10 11:19 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BDBE44.3060504@redhat.com \
--to=pbonzini@redhat.com \
--cc=Ian.Campbell@citrix.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).